From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D9741F03D9 for ; Thu, 14 May 2026 01:58:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778723884; cv=none; b=hJGtPXxd/jQtDYPGXB7sM1sQKrK6cDXc4YRtv3iO0Tbo0kef+GEEFrzxk3GqRfxI+p21wywcjfzUwNsEA+aGeXaFfQMcDT7MBNmPo8EN8iKqK4WiQHEJFP0PZnmcm9FO9cxhEsIGTWwyd5TOfWb13zGW+gnA1Ra2DyONkLBVosA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778723884; c=relaxed/simple; bh=QSENlRK6PdQcsKY4C3zA8cBazFvH+owMvKs28lxS/eo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=n+mECSCmpxCgwo8KMq2fEX+qspBmSHo+8a2iOa6FQciL5sf+whjjQ/ipIXHzYAIriJbvTLxTXPDMdcJWr+9T49P1VJgf7NtGD/z4KproeDI1gufRVmRnhzn8xDiFqabc5MfCRVg32qJyp3jeUp3zVOZaq/FZ3mLIkxXRNAqi5cM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p6dgzZ/7; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p6dgzZ/7" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778723870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AToiLp5s9PtrKKoXGsWO6tlmsClmnuo3iSqdPilSAGk=; b=p6dgzZ/7Yacdx0s+aWXec47EyIriW1zz34Onqj9sr6CuAAnZRu4MoJ2EtjU3BTP2kIWbh7 6WBMoNX3yl7+AcG6r33gP7883NE1GJ57Ssk9ZtZEpBXuRlgSQjY7/W4bnnMC15Cn8KPv7N ajjiPdB3+dfCiUtekxjft09YYSaBkDc= From: Qingfang Deng To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Felix Maurer , Sebastian Andrzej Siewior , Qingfang Deng , Petr Machata , linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH net-next v2] selftests: net: add tests for PPPoL2TP Date: Thu, 14 May 2026 09:57:32 +0800 Message-ID: <20260514015743.37869-1-qingfang.deng@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Add ping, iperf3, and recursion tests for PPPoL2TP. Assisted-by: Gemini:gemini-3-flash Signed-off-by: Qingfang Deng --- v2: - use named veth pair instead of netkit - reset RET prior to the recursion test v1: https://lore.kernel.org/netdev/20260508032158.67887-1-qingfang.deng@linux.dev tools/testing/selftests/net/ppp/Makefile | 1 + tools/testing/selftests/net/ppp/config | 2 + tools/testing/selftests/net/ppp/pppol2tp.sh | 95 +++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100755 tools/testing/selftests/net/ppp/pppol2tp.sh diff --git a/tools/testing/selftests/net/ppp/Makefile b/tools/testing/selftests/net/ppp/Makefile index b39b0abadde6..6036fa134351 100644 --- a/tools/testing/selftests/net/ppp/Makefile +++ b/tools/testing/selftests/net/ppp/Makefile @@ -5,6 +5,7 @@ top_srcdir = ../../../../.. TEST_PROGS := \ ppp_async.sh \ pppoe.sh \ + pppol2tp.sh \ # end of TEST_PROGS TEST_FILES := \ diff --git a/tools/testing/selftests/net/ppp/config b/tools/testing/selftests/net/ppp/config index b45d25c5b970..843545df8f03 100644 --- a/tools/testing/selftests/net/ppp/config +++ b/tools/testing/selftests/net/ppp/config @@ -1,4 +1,5 @@ CONFIG_IPV6=y +CONFIG_L2TP=m CONFIG_PACKET=y CONFIG_PPP=m CONFIG_PPP_ASYNC=m @@ -6,4 +7,5 @@ CONFIG_PPP_BSDCOMP=m CONFIG_PPP_DEFLATE=m CONFIG_PPPOE=m CONFIG_PPPOE_HASH_BITS_4=y +CONFIG_PPPOL2TP=m CONFIG_VETH=y diff --git a/tools/testing/selftests/net/ppp/pppol2tp.sh b/tools/testing/selftests/net/ppp/pppol2tp.sh new file mode 100755 index 000000000000..5b592785f1f9 --- /dev/null +++ b/tools/testing/selftests/net/ppp/pppol2tp.sh @@ -0,0 +1,95 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +source ppp_common.sh + +VETH_SERVER="veth-server" +VETH_CLIENT="veth-client" +OUTER_IP_SERVER="172.16.1.1" +OUTER_IP_CLIENT="172.16.1.2" + +PPPOL2TP_DIR=$(mktemp -d /tmp/pppol2tp.XXXXXX) + +# shellcheck disable=SC2329 +cleanup() { + cleanup_all_ns + rm -rf "$PPPOL2TP_DIR" +} + +trap cleanup EXIT + +require_command xl2tpd +ppp_common_init +modprobe -q l2tp_ppp + +# Create the veth pair +ip link add "$VETH_SERVER" type veth peer name "$VETH_CLIENT" +ip link set "$VETH_SERVER" netns "$NS_SERVER" +ip link set "$VETH_CLIENT" netns "$NS_CLIENT" +ip -netns "$NS_SERVER" link set "$VETH_SERVER" up +ip -netns "$NS_CLIENT" link set "$VETH_CLIENT" up +ip -netns "$NS_SERVER" address add dev "$VETH_SERVER" "$OUTER_IP_SERVER" peer "$OUTER_IP_CLIENT" +ip -netns "$NS_CLIENT" address add dev "$VETH_CLIENT" "$OUTER_IP_CLIENT" peer "$OUTER_IP_SERVER" + +# Generate configuration files +cat > "$PPPOL2TP_DIR/l2tp-server.conf" < "$PPPOL2TP_DIR/l2tp-client.conf" < "$PPPOL2TP_DIR/l2tp-client.control" + +ppp_test_connectivity + +log_test "PPPoL2TP" + +# Recursion test +RET=0 +# Delete route to LNS IP +ip -netns "$NS_CLIENT" route del "$OUTER_IP_SERVER" +# Add default route through ppp0 +ip -netns "$NS_CLIENT" route add default dev ppp0 +# ping (we expect the ping to fail but not deadlock the system) +ip netns exec "$NS_CLIENT" ping -c 1 "$IP_SERVER" -w 1 +check_fail $? + +log_test "PPPoL2TP Recursion" + +exit "$EXIT_STATUS" -- 2.43.0