From: Jakub Kicinski <kuba@kernel.org>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: netlink: warn on overwriting extack message
Date: Thu, 14 May 2026 16:57:15 -0700 [thread overview]
Message-ID: <20260514165715.3734df47@kernel.org> (raw)
In-Reply-To: <20260513143219.3327287-1-mmyangfl@gmail.com>
On Wed, 13 May 2026 22:32:16 +0800 David Yang wrote:
> When NL_SET_ERR_MSG is called more than once on the same extack, the
> existing message is silently overwritten. This is hard to detect via
> static analysis. Emit a rate-limited warning so these cases become
> visible.
I don't think this is worth the bloat.
There's only so much we can do for poorly written code.
--
pw-bot: reject
prev parent reply other threads:[~2026-05-14 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 14:32 [PATCH net-next] net: netlink: warn on overwriting extack message David Yang
2026-05-14 23:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514165715.3734df47@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox