From: Jakub Kicinski <kuba@kernel.org>
To: <qiu.yutan@zte.com.cn>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yang.chuan1@zte.com.cn>, <huang.jian@zte.com.cn>,
<zhou.shizhen@zte.com.cn>, <zhang.dongyu1@zte.com.cn>,
<ye.guojin@zte.com.cn>, <yang.wei20@zte.com.cn>,
<zhang.lin16@zte.com.cn>, <li.hao40@zte.com.cn>
Subject: Re: [PATCH net-next] net: arp: Fix the coding style issue regarding spaces in arp_state_to_flags()
Date: Thu, 14 May 2026 17:57:31 -0700 [thread overview]
Message-ID: <20260514175731.1ef2bb5e@kernel.org> (raw)
In-Reply-To: <20260512143931584Zv3UzxnMq14MaQPmsK3VX@zte.com.cn>
On Tue, 12 May 2026 14:39:31 +0800 (CST) qiu.yutan@zte.com.cn wrote:
> According to the kernel's coding style, the binary operator & should
> have a space on each side.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Quoting documentation:
Clean-up patches
~~~~~~~~~~~~~~~~
Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work. For example:
* Addressing ``checkpatch.pl``, and other trivial coding style warnings
* Addressing :ref:`Local variable ordering<rcs>` issues
* Conversions to device-managed APIs (``devm_`` helpers)
This is because it is felt that the churn that such changes produce comes
at a greater cost than the value of such clean-ups.
Conversely, spelling and grammar fixes are not discouraged.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
--
pw-bot: reject
prev parent reply other threads:[~2026-05-15 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 6:39 [PATCH net-next] net: arp: Fix the coding style issue regarding spaces in arp_state_to_flags() qiu.yutan
2026-05-15 0:57 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514175731.1ef2bb5e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=huang.jian@zte.com.cn \
--cc=li.hao40@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiu.yutan@zte.com.cn \
--cc=yang.chuan1@zte.com.cn \
--cc=yang.wei20@zte.com.cn \
--cc=ye.guojin@zte.com.cn \
--cc=zhang.dongyu1@zte.com.cn \
--cc=zhang.lin16@zte.com.cn \
--cc=zhou.shizhen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox