From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3715D35E1DD for ; Fri, 15 May 2026 19:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778871864; cv=none; b=gRszGYa9sPuoKYVE0E7MC5nkcksqDNiwEPx1UL3lYR5FmbA2N5JLWB79DMrf7g3QLySDgh7NG5auMl6fs4xjNdxNgqd/eRQ9ZoCUbtDFoENe4Th4UPvgy3OLvTyxvk6h1CAdwGCHn0nttw2w4V6AfRGiVmOfHrguBxTUENKc1qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778871864; c=relaxed/simple; bh=09YivHPBajfDVmwpC8AfPK2sWbUMOJPh9A9V77KLDyE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iuQnaBxzfVFZoNQgFrw/xZRDDskOXVmfyhW9AptduA7I9uxdwpY8PaQDeoHicG4GeaV6mIOImtSbzSnEgXE+t2Ji5Xx8TyC1Og36BFgBgT6PkJoRbXZA0ifd2x65PjqbaArFsKGR5BG2QfXQSk7wmDV1/k+gSWJibxMlpr7gdPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TyJSC6BU; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TyJSC6BU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778871863; x=1810407863; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=09YivHPBajfDVmwpC8AfPK2sWbUMOJPh9A9V77KLDyE=; b=TyJSC6BUd0UtA5DHHnKylOu1vrK5i5W+Nu24lA8NJTltKsMBVb+8iIzg lLBIEBM3lfuCn97Sm+u0fmWQOYpMXIDcffxbJlsDx/vpXQkCqPq+92QAu JOLDTb6MlEStvdUuj5s+SUbpaByv1i2LIxnwEGBpxpLaPq7vLWEqBIIo6 KsSuh3wlpaJUxpip1Fefvd3bNu3oS0ucYc/GI46Iu/W1I+R0udRCUoDJK 9briGNzY3PuNczNEwg+rJTVudxpdpMbl+SeNnH008qq26KuQH8OvYKab5 b821yfiabFT3xww2VJB1hULE+2AA7WXyBnCCytgGajrMDMk6mlO7ywuTL g==; X-CSE-ConnectionGUID: iDfoJ93HTI+nA4xMzTp7Lg== X-CSE-MsgGUID: WZ1iJhFPSae1y9h/G1gcDw== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="79725699" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="79725699" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 12:04:23 -0700 X-CSE-ConnectionGUID: d4OS39XeSxqoHdEyxEEMXw== X-CSE-MsgGUID: PcxD+8NdThW0Cy+MYQ+MJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="238895629" Received: from amlin-019-225.igk.intel.com ([10.102.19.225]) by orviesa009.jf.intel.com with ESMTP; 15 May 2026 12:04:21 -0700 From: Aleksandr Loktionov To: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com Cc: netdev@vger.kernel.org, Simon Horman , Marcin Szycik Subject: [PATCH iwl-net v5 2/4] ixgbe: fix cls_u32 nexthdr path returning success when no entry installed Date: Fri, 15 May 2026 21:04:15 +0200 Message-ID: <20260515090000.5112345-3-aleksandr.loktionov@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260515090000.5112345-1-aleksandr.loktionov@intel.com> References: <20260515090000.5112345-1-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ixgbe_configure_clsu32() returns 0 (success) after the nexthdr loop even when ixgbe_clsu32_build_input() fails for every candidate entry and no jump-table slot is actually programmed. Callers that test the return value would then falsely believe the filter was installed. The variable 'err' already tracks the last ixgbe_clsu32_build_input() return value; if the loop completes with a successful break, err is 0. If all attempts failed, err holds the last failure code. Change the unconditional 'return 0' to 'return err' so errors are propagated correctly. Fixes: 1cdaaf5405ba ("ixgbe: Match on multiple headers for cls_u32 offloads") Signed-off-by: Aleksandr Loktionov Cc: stable@vger.kernel.org Reviewed-by: Simon Horman Reviewed-by: Marcin Szycik --- v2 -> v3: - Add Reviewed-by: Simon Horman; no code change. v1 -> v2: - Add Fixes: tag; reroute from iwl-next to iwl-net (false-success return is a user-visible correctness bug, not a cleanup). drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 210c7b9..6e7f8a9 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -10311,7 +10311,7 @@ static int ixgbe_configure_clsu32(struct ixgbe_adapter *adapter, kfree(jump); } } - return 0; + return err; } input = kzalloc_obj(*input); -- 2.52.0