From: Arnd Bergmann <arnd@kernel.org>
To: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Martin KaFai Lau" <kafai@fb.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>, Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] bpf: test_run: reduce kernel stack usage
Date: Fri, 15 May 2026 13:25:37 +0200 [thread overview]
Message-ID: <20260515113102.2389020-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The xdp_test_data structure is really too large to put on the stack
and results in one of the largest stack frames in the kernel:
net/bpf/test_run.c: In function 'bpf_test_run_xdp_live':
net/bpf/test_run.c:387:1: error: the frame size of 1608 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]
Reduce this using dynamic allocation, which avoids around 1KB of
stack usage.
Fixes: b530e9e1063e ("bpf: Add "live packet" mode for XDP in BPF_PROG_RUN")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
found while build testing s390 with gcc-16, had not seen this on
other architectures before.
---
net/bpf/test_run.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
index c9aea7052ba7..763891df02be 100644
--- a/net/bpf/test_run.c
+++ b/net/bpf/test_run.c
@@ -362,27 +362,31 @@ static int bpf_test_run_xdp_live(struct bpf_prog *prog, struct xdp_buff *ctx,
u32 repeat, u32 batch_size, u32 *time)
{
- struct xdp_test_data xdp = { .batch_size = batch_size };
+ struct xdp_test_data *xdp __free(kfree) = kzalloc_obj(*xdp);
struct bpf_test_timer t = {};
int ret;
+ if (!xdp)
+ return -ENOMEM;
+
if (!repeat)
repeat = 1;
- ret = xdp_test_run_setup(&xdp, ctx);
+ xdp->batch_size = batch_size;
+ ret = xdp_test_run_setup(xdp, ctx);
if (ret)
return ret;
bpf_test_timer_enter(&t);
do {
- xdp.frame_cnt = 0;
- ret = xdp_test_run_batch(&xdp, prog, repeat - t.i);
+ xdp->frame_cnt = 0;
+ ret = xdp_test_run_batch(xdp, prog, repeat - t.i);
if (unlikely(ret < 0))
break;
- } while (bpf_test_timer_continue(&t, xdp.frame_cnt, repeat, &ret, time));
+ } while (bpf_test_timer_continue(&t, xdp->frame_cnt, repeat, &ret, time));
bpf_test_timer_leave(&t);
- xdp_test_run_teardown(&xdp);
+ xdp_test_run_teardown(xdp);
return ret;
}
--
2.39.5
next reply other threads:[~2026-05-15 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 11:25 Arnd Bergmann [this message]
2026-05-15 14:47 ` [PATCH] bpf: test_run: reduce kernel stack usage Alexei Starovoitov
2026-05-15 15:15 ` Arnd Bergmann
2026-05-15 16:13 ` Alexei Starovoitov
2026-05-15 18:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515113102.2389020-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=andrii@kernel.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=toke@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox