From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 499E2175A9A for ; Fri, 15 May 2026 23:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778886145; cv=none; b=I7LDRNyKch/VUJMo5cTITS4MHZ8Nh9VPNJyG+8oIoq51L/uiQTthOS+HbxVhdg+xrIHubMCFugCTdItXyxJN4YzHLi/Tfqd2ADT/i4ongZ7IdF7zcrhdbmFVBQD3Ba7oJER/TS+7HkRwFB3F2VW6M3w/oeQ3yShf4OGyKzqoqwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778886145; c=relaxed/simple; bh=1DUODArNbaH8yEbiFJ9EDpD31sJYNQmjl95D66fLDBs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dQ8SPzvxOhxBgjeTIv/6L4lcvRKLGQbXjAU5haAl9BnZCxXLTyjBnJO26I49qGefwXIoJvTqsFgfyKlQqLhhBRtrg1yKB6P7if8E7vtTXs4vCq6zgUdwPH19TH9RjikV1VRcWZzA33mOgJuCkAFPl1JrXpocNpEe99tM/Msrf10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SzIikISo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SzIikISo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B093C2BCB0; Fri, 15 May 2026 23:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778886144; bh=1DUODArNbaH8yEbiFJ9EDpD31sJYNQmjl95D66fLDBs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SzIikISoEhqbUbuw1EOSIxYKfi98AkJsQmJ7Vu+B/qn8wADW1pJFSMcI+ymNTz7/m Gde0jVmCIo3Oin6c6hAglBc1lfEto44YtgDS7q5Tbuk+7PyTnDS9Jpe8FVN/6r7CLl yIZ/CUQxfGSq7q7Pz5H1SfA4cVWnjPsalWg4e8yAH1x4vdZ0d4TP+q9r4RIsUKcffN NWK2OA5n7pxGhoUu1Te81UJmVe1GUvONbMaVhnsVwIsDYWvph+Z4iJTeTDdD1NmS24 tREb11hG+mKGAyvJGnvhk7O4sIy0ZNWjSPx13xqGYRrdTG/QTYxDgSImO52qT/IY2x ngRmXPqM4rMZw== Date: Fri, 15 May 2026 16:02:23 -0700 From: Jakub Kicinski To: Eric Joyner Cc: netdev@vger.kernel.org, Brett Creeley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [PATCH net-next v3 5/5] ionic: Add .get_fec_stats ethtool handler Message-ID: <20260515160223.1a6b62ea@kernel.org> In-Reply-To: <8fb773c1-411a-4b61-915f-5111210abe1f@amd.com> References: <20260512224421.25236-1-eric.joyner@amd.com> <20260512224421.25236-6-eric.joyner@amd.com> <20260514183209.48fa771a@kernel.org> <8fb773c1-411a-4b61-915f-5111210abe1f@amd.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 15 May 2026 12:59:04 -0700 Eric Joyner wrote: > On 5/14/2026 6:32 PM, Jakub Kicinski wrote: > > On Tue, 12 May 2026 15:44:21 -0700 Eric Joyner wrote: > >> This includes 802.3ck FEC histogram data that some newer > >> hardware collects. > > > > Ah. "Some newer hardware"? As Sashiko points out the standard stats > > are designed trying to avoid "does 0 mean unsupported or 0" ambiguity. > > You need to figure out if the device reports them and if not - don't > > set ranges. > > Unfortunately, there's no proper/good way to do this. A stopgap measure > would be to use a rough proxy measure like checking the ASIC generation; and > then we can implement a better way in the firmware/driver following that. The FW definitely knows, so it's a SMOC. Could you respin just patch 2 for now, or does it suffer from the same shortcoming?