From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pdx-out-010.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-010.esa.us-west-2.outbound.mail-perimeter.amazon.com [52.12.53.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0A85362149; Fri, 15 May 2026 16:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.12.53.23 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778863279; cv=none; b=JJfLwT0Fbwyc9n9W1DjKCZck7NGwXh+IFTBO6ohSA046IN4+RqjTsV/N4COtH/lhUsyLoeTEbycsd9X5co22NALp0DvubM0n/b2LI/RZLHShtncLCoeFe//mTqhD/CUftWidYPPcabcbteD8RFYJa4CXDsqlVIZ+UWjsAT/fI7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778863279; c=relaxed/simple; bh=/dTpzmkZyWHnlgGcUYC/4QWQzSm362ukIfQOXyZRdTM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kwRzbbMzYJ07JInfsab5PDRASN4q4QQwBvGPYJ0zrSZtXMMrf/HTfyjRHI7hQrch9hmrqT1iRdI3g1Gx2LXos8qrL9ji380QmEZJoUAfdQftfB/t23nb4EUVmVGbGg3kpg5/TjSNgkCdyYw/WKhvr0FjyCvlBEf0RP2cpKJTYbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.com; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=qyT3arCk; arc=none smtp.client-ip=52.12.53.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="qyT3arCk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1778863273; x=1810399273; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fWOAAnFub8AMT7FdRtKJc/Hk8Pxdbj6VVKcyAdlo/Ys=; b=qyT3arCkdQi786AyuSvcE9Qib664zY/BHlmsRyC6+aVW5c0Qe0eMWGqY 8dC281aIEFBC9CNfT2hfSIl/fu1p43j1sLWmPmuA1vVzcPcBizq8tScDM 2BcFfYuj8uFJfTN5sDShutBC0XKZA9z1X0eNJv5PqaJv8MT2rSZeYDkyD VK4S+KEmG53hy07A/Mvznyxy49z+g8ghqLvbYFAQcVkaCKuMnvgKomnZC tNHSIJu4HkCtJkIliYUyZfOYvYgfVRlt4my2NZH/3o+CWcMZa8mpgjfHL 8WEYiQJza8D4x1QyCZFQDpNwo9OhQ/ceKZsGh38ZVD3m2kUqiBGFBliMq Q==; X-CSE-ConnectionGUID: USFGnvt9SVS8HV87xe6geQ== X-CSE-MsgGUID: 7uSUA2VUScGPrPsI6289RQ== X-IronPort-AV: E=Sophos;i="6.23,236,1770595200"; d="scan'208";a="19619363" Received: from ip-10-5-9-48.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.9.48]) by internal-pdx-out-010.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 16:41:10 +0000 Received: from EX19MTAUWB002.ant.amazon.com [205.251.233.48:18738] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.34.21:2525] with esmtp (Farcaster) id 8f346a1e-85f8-4e42-8868-b697e4068fba; Fri, 15 May 2026 16:41:09 +0000 (UTC) X-Farcaster-Flow-ID: 8f346a1e-85f8-4e42-8868-b697e4068fba Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 15 May 2026 16:41:07 +0000 Received: from dev-dsk-akiyano-1c-2138b29d.eu-west-1.amazon.com (172.19.83.6) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.37; Fri, 15 May 2026 16:41:02 +0000 From: Arthur Kiyanovski To: David Miller , Jakub Kicinski , CC: Arthur Kiyanovski , Richard Cochran , Eric Dumazet , Paolo Abeni , David Woodhouse , Thomas Gleixner , Miroslav Lichvar , Andrew Lunn , Wen Gu , Xuan Zhuo , David Woodhouse , "Yonatan Sarna" , Zorik Machulsky , "Alexander Matushevsky" , Saeed Bshara , Matt Wilson , Anthony Liguori , Nafea Bshara , Evgeny Schmeilin , Netanel Belgazal , Ali Saidi , Benjamin Herrenschmidt , Noam Dagan , David Arinzon , Evgeny Ostrovsky , Ofir Tabachnik , Amit Bernstein , , , Subject: [PATCH v3 net-next 2/7] selftests/ptp: Extract print_system_timestamp helper in testptp Date: Fri, 15 May 2026 16:40:22 +0000 Message-ID: <20260515164033.6403-3-akiyano@amazon.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515164033.6403-1-akiyano@amazon.com> References: <20260515164033.6403-1-akiyano@amazon.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D038UWB003.ant.amazon.com (10.13.139.157) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Extract the repeated switch-on-clockid pattern used for printing system timestamps into a reusable helper function. This removes code duplication in the -x (PTP_SYS_OFFSET_EXTENDED) output path and prepares for additional callers. No functional change. Signed-off-by: Arthur Kiyanovski --- tools/testing/selftests/ptp/testptp.c | 70 ++++++++++++--------------- 1 file changed, 32 insertions(+), 38 deletions(-) diff --git a/tools/testing/selftests/ptp/testptp.c b/tools/testing/selftests/ptp/testptp.c index ed1e288..d3bcfd0 100644 --- a/tools/testing/selftests/ptp/testptp.c +++ b/tools/testing/selftests/ptp/testptp.c @@ -153,6 +153,28 @@ static void usage(char *progname) progname, PTP_MAX_SAMPLES); } +static void print_system_timestamp(int sample_num, __kernel_clockid_t clockid, + long long sec, unsigned int nsec, + const char *when) +{ + switch (clockid) { + case CLOCK_REALTIME: + printf("sample #%2d: real time %s: %lld.%09u\n", + sample_num, when, sec, nsec); + break; + case CLOCK_MONOTONIC: + printf("sample #%2d: monotonic time %s: %lld.%09u\n", + sample_num, when, sec, nsec); + break; + case CLOCK_MONOTONIC_RAW: + printf("sample #%2d: monotonic-raw time %s: %lld.%09u\n", + sample_num, when, sec, nsec); + break; + default: + break; + } +} + int main(int argc, char *argv[]) { struct ptp_clock_caps caps; @@ -608,46 +630,18 @@ int main(int argc, char *argv[]) getextended); for (i = 0; i < getextended; i++) { - switch (ext_clockid) { - case CLOCK_REALTIME: - printf("sample #%2d: real time before: %lld.%09u\n", - i, soe->ts[i][0].sec, - soe->ts[i][0].nsec); - break; - case CLOCK_MONOTONIC: - printf("sample #%2d: monotonic time before: %lld.%09u\n", - i, soe->ts[i][0].sec, - soe->ts[i][0].nsec); - break; - case CLOCK_MONOTONIC_RAW: - printf("sample #%2d: monotonic-raw time before: %lld.%09u\n", - i, soe->ts[i][0].sec, - soe->ts[i][0].nsec); - break; - default: - break; - } + print_system_timestamp(i, ext_clockid, + soe->ts[i][0].sec, + soe->ts[i][0].nsec, + "before"); + printf(" phc time: %lld.%09u\n", soe->ts[i][1].sec, soe->ts[i][1].nsec); - switch (ext_clockid) { - case CLOCK_REALTIME: - printf(" real time after: %lld.%09u\n", - soe->ts[i][2].sec, - soe->ts[i][2].nsec); - break; - case CLOCK_MONOTONIC: - printf(" monotonic time after: %lld.%09u\n", - soe->ts[i][2].sec, - soe->ts[i][2].nsec); - break; - case CLOCK_MONOTONIC_RAW: - printf(" monotonic-raw time after: %lld.%09u\n", - soe->ts[i][2].sec, - soe->ts[i][2].nsec); - break; - default: - break; - } + + print_system_timestamp(i, ext_clockid, + soe->ts[i][2].sec, + soe->ts[i][2].nsec, + "after"); } } -- 2.47.3