From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E369030C165; Fri, 15 May 2026 18:24:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778869470; cv=none; b=tAKHGZ/fxFdqtsl1sVzWtITGvI0W6C4kAnpUX8Qe7fdwkBtvULzW996y4drQUviUesI4TywrYwGwjMoyUIEpT6oetSdw4bZ39NVT28ZHMrQR6+irPZWUBzXdmPlgGJM48UhOao7+9Eo+A+kt1wfqkRyHgjE4AYwVzWenr0J2ks4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778869470; c=relaxed/simple; bh=UDLtv1sa6VPE03Wq5XDbtMstZ4jGoR2GbWUIJEV9FHY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dCGWoxbcnMwsBUmAWGUnJbpDINqckVlBOe1iT2iAFssbr9iuVXhErho6+aziIus9ZEQsPpPRwQLDKUapFJIM59ZflQwWiAZJrOHNN7uBK9uKd/qgOz6d8+yfSVH+ZNsE3q6CmyPLxHhWf7MfLDBUMOBgfsEEx5al7519AGnuuYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fJR+i2FS; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fJR+i2FS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778869469; x=1810405469; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UDLtv1sa6VPE03Wq5XDbtMstZ4jGoR2GbWUIJEV9FHY=; b=fJR+i2FS2adjO4Mz46cL6FYsexZ5N0CMlVt9uo3XORsCJd0/2jMz7xbV Ztd0hlWBFJxYffJp8bHUeqU8MWlu3TQS40vIJMFkoxpBrfJt4lAk+Q41r VcjExqUE5RNnQZInE/FCkI9oX6deJ4fkZcHmpH4369Fte+k/vf7xcFbHG Th32vkiRik2zTzN5dA6wA5LjCZtPu5zVhaPkXjjOWxyEkJ9WW1PW47TVV /2E2KDeKd0wMix4mVQWGX6gKBfFm1v4KMIzCuD0P3SySbV7Glv5tllfuA jOo8Hh3F0Kx41+YZgUQZIvWoeRA9dVsD4qDrAhcxd5NYOgyFsvgd5vuRU w==; X-CSE-ConnectionGUID: YUtLx5k5QOm898E4Rf0nfg== X-CSE-MsgGUID: dVGpQE2UQF2U5HlLbapODQ== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="83701133" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="83701133" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 11:24:27 -0700 X-CSE-ConnectionGUID: wXIYKSG0SQGd+MnpvuIQCw== X-CSE-MsgGUID: bTrlj8T1QdWQq2enDigtxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="238647439" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orviesa008.jf.intel.com with ESMTP; 15 May 2026 11:24:26 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org Cc: Jose Ignacio Tornos Martinez , anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, stable@vger.kernel.org, Jacob Keller , Michal Swiatkowski , Paul Menzel , Rafal Romanowski Subject: [PATCH net 02/10] ice: fix VF queue configuration with low MTU values Date: Fri, 15 May 2026 11:24:09 -0700 Message-ID: <20260515182419.1597859-3-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260515182419.1597859-1-anthony.l.nguyen@intel.com> References: <20260515182419.1597859-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jose Ignacio Tornos Martinez The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes. The iavf driver calculates databuffer_size based on the MTU using: databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128) where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN). For MTU values below 871: MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected) MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted) The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of 68 bytes. I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations. Fixes: 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message") cc: stable@vger.kernel.org Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Jacob Keller Reviewed-by: Michal Swiatkowski Reviewed-by: Paul Menzel Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/virt/queues.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/virt/queues.c b/drivers/net/ethernet/intel/ice/virt/queues.c index f73d5a3e83d4..31be2f76181c 100644 --- a/drivers/net/ethernet/intel/ice/virt/queues.c +++ b/drivers/net/ethernet/intel/ice/virt/queues.c @@ -840,7 +840,7 @@ int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg) if (qpi->rxq.databuffer_size != 0 && (qpi->rxq.databuffer_size > ((16 * 1024) - 128) || - qpi->rxq.databuffer_size < 1024)) + qpi->rxq.databuffer_size < 128)) goto error_param; ring->rx_buf_len = qpi->rxq.databuffer_size; -- 2.47.1