From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 506804F799D for ; Fri, 15 May 2026 18:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778869473; cv=none; b=ECa/mtq1iiUtm650Dxai0XGpROGWlm/Hy9eJVkUi1q6mUCf9xlIGUcu/fCYnY/MumYJStAIpSLFK/44SqQM6z9Zm3e+b24zFzjEQZq/h1zqkL4W44D8XhpsrU05NGzs04y/wQhPbB5FU9sQiwPH47M/V+PRadIRkT2jE/v47pG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778869473; c=relaxed/simple; bh=alAtIcDGq8AoCEBcSFMBrfnxk9+5oc2dmtoR9mus5Dk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mvIQXvpDL0D15c7An3DjNC+1CNJRlFJnZqheaIuW17yqvTQTNMXxuMoGPc+2nVVZENrwwo7JChhU4r8JNGAX/D6C1cGUxwzTGiYRUSai3yMxZZi/iSsIaRFFw01DyiDgeLAJPdcpxUhqpMbRUo2PQ/Ev2w61udzqLswJwglWh6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NxNDIPWt; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NxNDIPWt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778869472; x=1810405472; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=alAtIcDGq8AoCEBcSFMBrfnxk9+5oc2dmtoR9mus5Dk=; b=NxNDIPWtToYZM4lXRoROr6Nd7aWvXkehYLXt3zAAiEsOxiUcaFmxZ/s9 efnTZUrM0iJONIzIGUoE9Qic1NKo3LfAkCsjjdneaSpfe+KpitQmePpk2 qwxW9XxER/sG3rqfyFlmT5l7PdwoqlPA+iR9yFKw7PYPkq5thTjI3Q/ak aPucIv0jy0bFMd51eKGBrmO13H07ykuZVF8vQaAqmJbcBdrIi0R7CLuYD Fslh0JASDc44opEPxCqOMFqbQaqh1Ija6IEd1dMaNSMtA1pGQzyyswgjO p803CbbMGJC88XX4/CFSb34zZcVFC1PbRHmKjF/pO2bX7C0DMvK2ZeKFG Q==; X-CSE-ConnectionGUID: wedFNbYZQCK0bYwPW1kT7Q== X-CSE-MsgGUID: PKx3Ma0aTDyZXD/obZL6rQ== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="83701175" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="83701175" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 11:24:27 -0700 X-CSE-ConnectionGUID: bwItMD6zThiGdtG3E0MpVA== X-CSE-MsgGUID: 5WLWAEk3T9GGBqs9YdWJdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="238647457" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orviesa008.jf.intel.com with ESMTP; 15 May 2026 11:24:27 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org Cc: Kohei Enju , anthony.l.nguyen@intel.com, dima.ruinskiy@intel.com, chwee.lin.choong@intel.com, faizal.abdul.rahim@linux.intel.com, vladimir.oltean@nxp.com, vinicius.gomes@intel.com, horms@kernel.org, kohei.enju@gmail.com, Aleksandr Loktionov , Avigail Dahan Subject: [PATCH net 08/10] igc: set tx buffer type for SMD frames Date: Fri, 15 May 2026 11:24:15 -0700 Message-ID: <20260515182419.1597859-9-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260515182419.1597859-1-anthony.l.nguyen@intel.com> References: <20260515182419.1597859-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kohei Enju Sashiko pointed out that igc_fpe_init_smd_frame() initializes igc_tx_buffer fields for an SMD skb, but does not set the buffer type: https://sashiko.dev/#/patchset/20260415025226.114115-1-kohei%40enjuk.jp Since igc_tx_buffer entries are reused, a stale XDP or XSK type can remain and make TX completion use the wrong cleanup path. Set the buffer type to IGC_TX_BUFFER_TYPE_SKB. Fixes: 5422570c0010 ("igc: add support for frame preemption verification") Signed-off-by: Kohei Enju Reviewed-by: Aleksandr Loktionov Reviewed-by: Simon Horman Tested-by: Avigail Dahan Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_tsn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c index 8a110145bfee..725ba253165c 100644 --- a/drivers/net/ethernet/intel/igc/igc_tsn.c +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c @@ -34,6 +34,7 @@ static int igc_fpe_init_smd_frame(struct igc_ring *ring, return -ENOMEM; } + buffer->type = IGC_TX_BUFFER_TYPE_SKB; buffer->skb = skb; buffer->protocol = 0; buffer->bytecount = skb->len; -- 2.47.1