From: Qi Tang <tpluszz77@gmail.com>
To: kuba@kernel.org, willemdebruijn.kernel@gmail.com
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Qi Tang <tpluszz77@gmail.com>
Subject: Re: [PATCH net v4] ipv6: validate extension header length before copying to cmsg
Date: Sat, 16 May 2026 23:31:55 +0800 [thread overview]
Message-ID: <20260516153155.2678332-1-tpluszz77@gmail.com> (raw)
In-Reply-To: <willemdebruijn.kernel.1c02e791312d@gmail.com>
On Sat, 16 May 2026 at 09:41:07 -0400, Willem de Bruijn wrote:
> Jakub Kicinski wrote:
> > return (len <= skb_tail_pointer(skb) - ptr) ? len : 0;
>
> If making changes, also time to replace the open coded offset
> with sizeof ipv6_opt_hdr and opt_hdr->hdrlen?
> Or perhaps better left for net-next.
Thanks, both make sense. I'll fold the tail-ptr subtraction
into v5 and post the typed-access refactor against net-next
right after.
Qi
prev parent reply other threads:[~2026-05-16 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 3:58 [PATCH net v4] ipv6: validate extension header length before copying to cmsg Qi Tang
2026-05-16 0:55 ` Jakub Kicinski
2026-05-16 13:41 ` Willem de Bruijn
2026-05-16 15:31 ` Qi Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516153155.2678332-1-tpluszz77@gmail.com \
--to=tpluszz77@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox