From: Xingwang Xiang <v3rdant.xiang@gmail.com>
To: john.fastabend@gmail.com, kuba@kernel.org, mrpre@163.com
Cc: jakub@cloudflare.com, sd@queasysnail.net, davem@davemloft.net,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
daniel@iogearbox.net, bpf@vger.kernel.org,
Xingwang Xiang <v3rdant.xiang@gmail.com>
Subject: [PATCH net v5 0/2] bpf, skmsg: fix verdict sk_data_ready racing with ktls rx
Date: Sun, 17 May 2026 23:56:25 +0900 [thread overview]
Message-ID: <20260517145630.20521-1-v3rdant.xiang@gmail.com> (raw)
sk_psock_verdict_data_ready() lacks the tls_sw_has_ctx_rx() guard that
sk_psock_strp_data_ready() gained in e91de6afa81c. When a socket is
inserted into a sockmap (BPF_SK_SKB_VERDICT) before TLS RX is configured,
the missing guard causes tcp_read_skb() to drain sk_receive_queue without
advancing copied_seq, leaving a dangling frag_list pointer that
tls_decrypt_sg() walks — a use-after-free.
Patch 1 mirrors the fix from e91de6afa81c: add the tls_sw_has_ctx_rx()
check to sk_psock_verdict_data_ready() so that when a TLS RX context is
present the function defers to psock->saved_data_ready (sock_def_readable)
instead of calling tcp_read_skb().
Patch 2 adds a selftest that drives the vulnerable sequence end-to-end
and verifies recv() returns the correct decrypted data.
Xingwang Xiang (2):
bpf, skmsg: fix verdict sk_data_ready racing with ktls rx
selftests/bpf: add regression test for ktls+sockmap verdict UAF
net/core/skmsg.c | 9 +-
.../selftests/bpf/prog_tests/sockmap_ktls.c | 103 ++++++++++++++++++
.../selftests/bpf/progs/test_sockmap_ktls.c | 21 ++++
3 files changed, 131 insertions(+), 2 deletions(-)
next reply other threads:[~2026-05-17 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 14:56 Xingwang Xiang [this message]
2026-05-17 14:56 ` [PATCH net v5 1/2] bpf, skmsg: fix verdict sk_data_ready racing with ktls rx Xingwang Xiang
2026-05-17 14:56 ` [PATCH net v5 2/2] selftests/bpf: add regression test for ktls+sockmap verdict UAF Xingwang Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517145630.20521-1-v3rdant.xiang@gmail.com \
--to=v3rdant.xiang@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=mrpre@163.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox