From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linuxppc-dev@lists.ozlabs.org (open list:FREESCALE QUICC ENGINE
UCC ETHERNET DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net-next] net: ucc_geth: Batch RX packets before stack handoff
Date: Sun, 17 May 2026 12:28:56 -0700 [thread overview]
Message-ID: <20260517192856.3925-1-rosenp@gmail.com> (raw)
Collect received skbs on a local list during RX polling and pass the
completed batch to netif_receive_skb_list(). This lets the networking
stack process packets from a poll cycle in bulk instead of handing each
skb up individually.
Speedup tested with bidirectional iperf3.
Before:
[ ID][Role] Interval Transfer Bitrate Retr
[ 5][TX-C] 0.00-10.00 sec 490 MBytes 411 Mbits/sec sender
[ 5][TX-C] 0.00-10.01 sec 488 MBytes 409 Mbits/sec receiver
[ 7][RX-C] 0.00-10.00 sec 176 MBytes 147 Mbits/sec 167 sender
[ 7][RX-C] 0.00-10.01 sec 175 MBytes 146 Mbits/sec receiver
After:
[ ID][Role] Interval Transfer Bitrate Retr
[ 5][TX-C] 0.00-10.00 sec 502 MBytes 421 Mbits/sec sender
[ 5][TX-C] 0.00-10.01 sec 501 MBytes 420 Mbits/sec receiver
[ 7][RX-C] 0.00-10.00 sec 212 MBytes 178 Mbits/sec 148 sender
[ 7][RX-C] 0.00-10.01 sec 211 MBytes 177 Mbits/sec receiver
Assisted-by: Codex:GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 7af4b5e3f38e..bce1079fc06a 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -2894,6 +2894,7 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit
u32 bd_status;
u8 *bdBuffer;
struct net_device *dev;
+ LIST_HEAD(rx_list);
ugeth_vdbg("%s: IN", __func__);
@@ -2934,7 +2935,7 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit
dev->stats.rx_bytes += length;
/* Send the packet up the stack */
- netif_receive_skb(skb);
+ list_add_tail(&skb->list, &rx_list);
}
skb = get_new_skb(ugeth, bd);
@@ -2960,6 +2961,8 @@ static int ucc_geth_rx(struct ucc_geth_private *ugeth, u8 rxQ, int rx_work_limit
bd_status = in_be32((u32 __iomem *)bd);
}
+ netif_receive_skb_list(&rx_list);
+
ugeth->rxBd[rxQ] = bd;
return howmany;
}
--
2.54.0
next reply other threads:[~2026-05-17 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 19:28 Rosen Penev [this message]
2026-05-17 20:24 ` [PATCH net-next] net: ucc_geth: Batch RX packets before stack handoff Andrew Lunn
2026-05-17 20:44 ` Rosen Penev
2026-05-17 21:01 ` Andrew Lunn
2026-05-20 23:57 ` Jakub Kicinski
2026-05-21 0:39 ` Rosen Penev
2026-05-21 0:45 ` Jakub Kicinski
2026-05-21 0:54 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517192856.3925-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox