From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE9378F2F; Tue, 19 May 2026 00:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779150681; cv=none; b=AlDANr1tPwucvlBQYLsNl+cChOpmzxRV6+yZZoezZb2nHUT87EDwCY9ancM2hY71ARYrCZKE3gzc2ACsA+DricWlq3olb9XT1LZ60K7aU0LOGMZd2cnmPZA9PwZorzhxNpnahtaSfukBkNPifjggsLpqOQC/Dl1XMiSG42QFXVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779150681; c=relaxed/simple; bh=Hn8nkfC6AtTfS13eIodWwSfN5loWrhpApSyYRHdiRas=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=h+vMfNYoiBTw8BVY9krbMNYBkwjp88y1N/j2lff5HT32SypwT3z1/nBpzgZdW7Xr9vs58/4nbcQ78z/wcAzaQRDsDljVCJFfI5GQi4S7FHUpCChS5DSRFeSojmCjkldcY4xzIBqJIj6VlOqP3mVlvZlG5r7/KPG4J2N+dd/r1QQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=C6+dbiLA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="C6+dbiLA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B115AC2BCB7; Tue, 19 May 2026 00:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1779150680; bh=Hn8nkfC6AtTfS13eIodWwSfN5loWrhpApSyYRHdiRas=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C6+dbiLA7Qe6C0VhGgzhrJtQCs/262xxPZUANDJfuzXdf5siA85xk0If9yuFKEStg JNM8zLf2+9wzRszYeOSqj6gJWs/TZFkhPTp+jsjM28txbYbPLzs+VTomvIr1FBeb5e QnXYXs9hEmJw+yiIH2VrSFVQO9NUCJT9ECzDRppg= Date: Mon, 18 May 2026 17:31:19 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: Byungchul Park , kernel_team@skhynix.com, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, david@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, ilias.apalodimas@linaro.org, kas@kernel.org, willy@infradead.org, baolin.wang@linux.alibaba.com, asml.silence@gmail.com, toke@redhat.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Revert "mm: introduce a new page type for page pool in page type" Message-Id: <20260518173119.f3348ec4cc66b793fed4cccf@linux-foundation.org> In-Reply-To: References: <20260515034701.17027-1-byungchul@sk.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 18 May 2026 12:00:11 +0100 Lorenzo Stoakes wrote: > Maybe worth putting [PATCH mm-hotfixes] just to make it clear this should be an > urgent hotfix? > > On Fri, May 15, 2026 at 12:47:01PM +0900, Byungchul Park wrote: > > This reverts commit db359fccf212e7fa3136e6edbed6228475646fd7. > > Maybe 'this reverts commit db359fccf212 ("...") and partially reverts commit > 735a309b4bfb9e ("...")
'? > > > > > Netpp page_type'ed pages might be used in mapping so as to use > > @_mapcount. However, since @page_type and @_mapcount are union'ed in > > struct page, these two can't be used at the same time. Revert the > > commit introducing page_type for Netpp for now. > > Yikes! > > > > > The patch will be retried once @page_type and @_mapcount get allowed to > > be used at the same time. > > > > The revert also includes removal of @page_type initialization part > > introduced by commit 735a309b4bfb9e ("net: add net_iov_init() and use it > > to initialize ->page_type"), which will be restored on the retry. > > As above maybe mentioning at top of commit msg, as right now this reads as a > pure revert of db359fccf212. I did : This reverts commit db359fccf212 ("mm: introduce a new page type for page : pool in page type") and a part of 735a309b4bfb9e ("net: add net_iov_init() : and use it > to initialize ->page_type"). > > > > Reported-by: Dragos Tatulea > > Closes: https://lore.kernel.org/all/982b9bc1-0a0a-4fc5-8e3a-3672db2b29a1@nvidia.com > > Fixes tag? I assume db359fccf212 ("mm: introduce a new page type for page pool in page type") is close enough. Both that and 735a309b4bfb9e are new in 7.1-rcX.