Netdev List
 help / color / mirror / Atom feed
From: Mohsin Bashir <mohsin.bashr@gmail.com>
To: netdev@vger.kernel.org
Cc: alexander.duyck@gmail.com, dsahern@kernel.org,
	stephen@networkplumber.org, pabeni@redhat.com, kuba@kernel.org,
	ernis@linux.microsoft.com, mohsin.bashr@gmail.com
Subject: [iproute2-next V4 0/6] netshaper: Extend netshaper support
Date: Mon, 18 May 2026 13:23:47 -0700	[thread overview]
Message-ID: <20260518202353.390827-1-mohsin.bashr@gmail.com> (raw)

From: Mohsin Bashir <hmohsin@meta.com>

This series extends the netshaper CLI with missing parameter support
and adds the group command for building scheduling hierarchies.

The existing netshaper tool only supports setting bw-max on individual
shapers. This series adds the remaining shaper attributes (bw-min,
weight) needed for TX scheduling, and introduces the group command
which ties leaf shapers to a parent node in a single operation.

Changelog:
V4:
  Patch 2:
  - Reorder BW_MAX/BW_MIN to BW_MIN/BW_MAX in usage text

  Patch 5:
  - Extract parse_scope_id() to share handle/parent scope+id parsing
  - Extract parse_leaves() with dynamic allocation, removing the
    static NET_SHAPER_MAX_LEAVES limit
  - Add per-leaf weight and priority support in group command
  - Remove inline declarations
  - Skip parent nest when parent not specified
  - Use goto free_leaves for error cleanup

  Patch 6:
  - Document per-leaf weight and priority usage

V3: https://lore.kernel.org/netdev/20260511183915.797792-1-mohsin.bashr@gmail.com/
V2: https://lore.kernel.org/netdev/20260509022353.3470738-1-mohsin.bashr@gmail.com/
V1: https://lore.kernel.org/netdev/20260501011611.3533573-1-mohsin.bashr@gmail.com/

Mohsin Bashir (6):
  netshaper: Extract parse_scope() and parse_rate() helpers
  netshaper: Add bw-min and weight parameter support
  netshaper: Extend show output with parent, bw-min and weight
  netshaper: Extract struct shaper_args and parse_shaper_arg() helper
  netshaper: Add group command for creating scheduling hierarchies
  netshaper: Update man page for new parameters and group command

 include/utils.h       |   1 +
 man/man8/netshaper.8  | 150 ++++++++++--
 netshaper/netshaper.c | 554 +++++++++++++++++++++++++++++++++++-------
 3 files changed, 597 insertions(+), 108 deletions(-)

-- 
2.53.0-Meta

             reply	other threads:[~2026-05-18 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 20:23 Mohsin Bashir [this message]
2026-05-18 20:23 ` [iproute2-next V4 1/6] netshaper: Extract parse_scope() and parse_rate() helpers Mohsin Bashir
2026-05-18 20:23 ` [iproute2-next V4 2/6] netshaper: Add bw-min and weight parameter support Mohsin Bashir
2026-05-18 20:23 ` [iproute2-next V4 3/6] netshaper: Extend show output with parent, bw-min and weight Mohsin Bashir
2026-05-18 20:23 ` [iproute2-next V4 4/6] netshaper: Extract struct shaper_args and parse_shaper_arg() helper Mohsin Bashir
2026-05-18 20:23 ` [iproute2-next V4 5/6] netshaper: Add group command for creating scheduling hierarchies Mohsin Bashir
2026-05-18 20:23 ` [iproute2-next V4 6/6] netshaper: Update man page for new parameters and group command Mohsin Bashir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518202353.390827-1-mohsin.bashr@gmail.com \
    --to=mohsin.bashr@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=ernis@linux.microsoft.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox