From: Muhammad Bilal <meatuni001@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, oe-linux-nfc@lists.linux.dev,
david+nfc@ixit.cz, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
stable@vger.kernel.org, Muhammad Bilal <meatuni001@gmail.com>
Subject: [PATCH net 0/2] nfc: llcp: fix OOB reads and integer bugs in TLV parsers
Date: Mon, 18 May 2026 21:19:35 -0400 [thread overview]
Message-ID: <20260519011937.12903-1-meatuni001@gmail.com> (raw)
This series fixes memory safety bugs in the NFC LLCP TLV parsing code,
reachable from a remote NFC peer via crafted LLCP frames.
Patch 1 fixes nfc_llcp_parse_gb_tlv() and nfc_llcp_parse_connection_tlv():
- u8 offset wraps to zero after 255 (widened to u16)
- OOB read of TLV header on truncated buffer
- OOB read of value field via attacker-controlled length byte
Patch 2 fixes nfc_llcp_recv_snl():
- OOB read of TLV header when tlv_len - offset == 1
- OOB read of SDREQ value via attacker-controlled length
- SIZE_MAX underflow when length == 0 in service_name_len,
bypassing the sn_len == 0 guard in nfc_llcp_sock_from_sn()
Previously reported to security@kernel.org on 2026-05-15. Willy Tarreau
advised posting to public lists as NFC is currently orphaned.
Muhammad Bilal (2):
nfc: llcp: fix OOB read and u8 offset wrap in TLV parsers
nfc: llcp: add missing bounds checks in nfc_llcp_recv_snl()
net/nfc/llcp_commands.c | 28 ++++++++++++++++++++++++++--
net/nfc/llcp_core.c | 23 +++++++++++++++++++++--
2 files changed, 47 insertions(+), 4 deletions(-)
--
2.54.0
next reply other threads:[~2026-05-19 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 1:19 Muhammad Bilal [this message]
2026-05-19 1:19 ` [PATCH net 1/2] nfc: llcp: fix OOB read and u8 offset wrap in TLV parsers Muhammad Bilal
2026-05-19 1:19 ` [PATCH net 2/2] nfc: llcp: add missing bounds checks in nfc_llcp_recv_snl() Muhammad Bilal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519011937.12903-1-meatuni001@gmail.com \
--to=meatuni001@gmail.com \
--cc=davem@davemloft.net \
--cc=david+nfc@ixit.cz \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox