From: Jakub Kicinski <kuba@kernel.org>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: <netdev@vger.kernel.org>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>, Petr Machata <petrm@nvidia.com>,
Breno Leitao <leitao@debian.org>, Nimrod Oren <noren@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Willem de Bruijn <willemb@google.com>,
Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] selftests: Use a master ssh connection for remote commands
Date: Tue, 19 May 2026 16:08:12 -0700 [thread overview]
Message-ID: <20260519160812.20678f72@kernel.org> (raw)
In-Reply-To: <20260518093653.551166-4-cratiu@nvidia.com>
On Mon, 18 May 2026 12:36:53 +0300 Cosmin Ratiu wrote:
> This finally implements this part of
> tools/testing/selftests/drivers/net/README.rst:
> "Using persistent SSH connections is strongly encouraged to avoid
> the latency of SSH connection setup on every command."
As this part of the README indicates, the expectation was that this
part of the setup will be handled outside of the harness itself.
After all something also has to set up the keys to make sure that
the hosts can actually log into each other, right?
I'm a bit on the fence, some extra Review / support tags would be
useful, and it'd be useful to make the code in patch 3 less ugly.
Patches 1 and 2 make sense.
prev parent reply other threads:[~2026-05-19 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 9:36 [PATCH net-next 0/3] selftests: Use a master ssh connection for remote commands Cosmin Ratiu
2026-05-18 9:36 ` [PATCH net-next 1/3] selftests: Disable stdin for remote commands over ssh Cosmin Ratiu
2026-05-18 9:36 ` [PATCH net-next 2/3] selftests: Wrap remote command executions in PTYs Cosmin Ratiu
2026-05-18 9:36 ` [PATCH net-next 3/3] selftests: Use a master ssh connection for remote commands Cosmin Ratiu
2026-05-19 23:08 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519160812.20678f72@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox