From: Jakub Kicinski <kuba@kernel.org>
To: David Thompson <davthompson@nvidia.com>
Cc: <bryan.whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: lan743x: permit VLAN-tagged packets up to configured MTU
Date: Tue, 19 May 2026 18:30:53 -0700 [thread overview]
Message-ID: <20260519183053.4ba5f3de@kernel.org> (raw)
In-Reply-To: <20260515192357.3631802-1-davthompson@nvidia.com>
On Fri, 15 May 2026 19:23:57 +0000 David Thompson wrote:
> The driver must set the MAC_RX.FSE bit before setting MAC_RX.RXEN to allow
> VLAN-tagged frames up to the interface MTU
AFAIU this sentence indicates that the double write
is intentional but could you make that more explicit?
Maybe mention whether this is based on experience or the AN?
It's going to be invaluable if someone ever sends a "cleanup"
to fold the writes into one..
> temp = lan743x_csr_read(adapter, MAC_RX);
> + temp |= MAC_RX_FSE_;
> + lan743x_csr_write(adapter, MAC_RX, temp);
> lan743x_csr_write(adapter, MAC_RX, temp | MAC_RX_RXEN_);
--
pw-bot: cr
next prev parent reply other threads:[~2026-05-20 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 19:23 [PATCH net] net: lan743x: permit VLAN-tagged packets up to configured MTU David Thompson
2026-05-20 1:30 ` Jakub Kicinski [this message]
2026-05-20 19:44 ` David Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519183053.4ba5f3de@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox