From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F0A81A316E; Wed, 20 May 2026 01:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779241754; cv=none; b=rrhjMKN3eKlLTeBGGGYe/Sr6+XZlYCHeRtH0OypHGiy6TEFZO2fhxqySEi1BC1ZidJER6vDPSsgm3snfpfC3oD2DNNMjtsWVfHe5cF22hv4y5CULhaj/DCn9AxR8sNQYq63oRX3X8PEIFb6nKjC0obBS4e8mni1fTutLXn3Fc18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779241754; c=relaxed/simple; bh=AhymG6cy2liaN1yN5luH1H+RF/bYVemyN4rEVk0XYMU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n0RV3gWFV7LFghRTOZKpOlra8NnoOyuuPr4lEdnmbop34/1sMBbVMTldAVH3euQ4kGT+nKS2RrpkwICl3C1NT2TpFAz4Zz5hX5Z/mDgR/KrQq7XLNXU0fHwEAxlL3Am6ETq4EyfuUqpZ9Px1iwBfH6R/rDWdRCH4H+CFlyOv2cI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D32cewKI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D32cewKI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34EEE1F00893; Wed, 20 May 2026 01:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779241752; bh=bXwiPD50uebpn5rsLXrIZRETt2LvlvnYNhWAe6HOn44=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=D32cewKILv6MxuLgEM9DcnTCoOnSLQoR7buvW9Km5EmdFHpjn74x6HzCWBxEENBVc xVWyPMNr1oZHxuKwnArHKeyfg+Ut39ZQOsm8yKxA74d1TJHrIA+GG8EGfaUDS3cLig HigXyvvTaE+UdSN7p2R940OSh70P8LdMU/v673vD1VdpADq1PwHoOKOEepkbU0ZGHj DyTTwf8u45fVbvefrFO4Zrwy27+ZQw3wJvtB6s1xq9S7rpxSujpvilgvDWDiqvCZQv C3fryWOWdP19ghyHs+cvqJTsN0uakCqaSs0rSb7F2KJ637U8v987LzsEkSTVsn7bME uLjCkhg0CLpdA== Date: Tue, 19 May 2026 18:49:11 -0700 From: Jakub Kicinski To: Jijie Shao Cc: , , , , , , , , , , , Subject: Re: [PATCH net-next 5/6] net: hns3: debugfs support for dumping fd rules Message-ID: <20260519184911.3b9e6ff7@kernel.org> In-Reply-To: <20260518093526.1109595-6-shaojijie@huawei.com> References: <20260518093526.1109595-1-shaojijie@huawei.com> <20260518093526.1109595-6-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 18 May 2026 17:35:25 +0800 Jijie Shao wrote: > Currently, the tc tool only supports adding and deleting rules from > the driver but does not support querying rules from the driver. > > This patch adds a rule dump file in debugfs to check whether the driver's > configuration matches the configuration issued by tc flow. drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c:2155:25: warning: diagnostic behavior may be improved by adding the 'format(printf, 5, 7)' attribute to the declaration of 'hclge_fd_dump_ptr' [-Wmissing-format-attribute] 2141 | static void hclge_fd_dump_ptr(struct seq_file *s, | __attribute__((format(printf, 5, 7))) 2142 | struct hclge_fd_rule *rule, 2143 | u32 type, const char *name, 2144 | const char *fmt, 2145 | const void *key, const void *mask) 2146 | { 2147 | if (rule->unused_tuple & BIT(type)) 2148 | return; 2149 | 2150 | seq_printf(s, "\t\t%s: ", name); 2151 | seq_printf(s, fmt, key); 2152 | seq_putc(s, '\n'); 2153 | 2154 | seq_printf(s, "\t\t%s_mask: ", name); 2155 | seq_printf(s, fmt, mask); | ^