From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A79DE2F90E0; Wed, 20 May 2026 02:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779242636; cv=none; b=RF0vWM87au29OXPmqaGvbbZWt4R/4zfWC5O4Xx3cvugBTFQsZlAp0tcxiuXGPsm0BIWYEd6EkWXi5Mmd9KZN01AIoWJB5CLtlCbi8dDwjSMSHK7BqIK07NGKimWy0iqzpPC5ntzWkzcnsJIChvOLWn9W5iPkOESC563zpBogoeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779242636; c=relaxed/simple; bh=PHSFUb2xWIygaB8BdJR82vxTInMPaKs6a6u2JDU/0lw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LP8HY78iLMh7yte93JcikYQ9hCQxnixyZNWcjHTMiY303eQmKr3Gb9dF5eZNakcJx3ZffgKt5YO/FKUX7466Jkp2bPFYSf3xaf8+m1LE6/wteFfiStYC1ZGaD9jjYLQHSQfPkF1Fw+RWwCeTfXyrrrdXv2DupgQ/5dWYVvHuXOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HMJV9gD3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HMJV9gD3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 063CC1F000E9; Wed, 20 May 2026 02:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779242633; bh=ocQsq1+vFFGeT8pSDWvbVmrW9r1vRZSSi+UTV8IUDNc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=HMJV9gD3J/8FSm3yRMprBfuOceeStGwP5AhKcy1Ib3GU+WgYPnGZTMTW9Jt+xjNSj GcXSRbJaBaDyj0hnOTZQEB9oLr7AVmQfameeSa5rJApEjdCeV0tjVO7Zs1tt0scDYD YonV5zcGWv/RKm2FFo9zbOWDW63jO0/Ev3eJUDMJn9VVO84ik8olQheaMD+7cMEsNP Iw3+BfVApUtvoerjG5/derKvpN0PzGhde6C1qWf+iyFpf/L1vUGpX3PABGiRjHS+jX i+QgaqBmyYKbwtQQXekTx2U/ebURKMuWobBBnxrrSWV/p7DiKc8qFpXhZqqdalij2r HnIZRyNlj75rg== Date: Tue, 19 May 2026 19:03:52 -0700 From: Jakub Kicinski To: Stefano Brivio Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Pavel Emelyanov , Laurent Vivier , David Gibson , Jon Maloy , Dmitry Safonov , Andrei Vagin , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Neal Cardwell , Kuniyuki Iwashima , Simon Horman , Shuah Khan Subject: Re: [PATCH net v2 0/2] Fix race condition between TCP_REPAIR dump and data receive Message-ID: <20260519190352.45c8478e@kernel.org> In-Reply-To: <20260518183424.3144867-1-sbrivio@redhat.com> References: <20260518183424.3144867-1-sbrivio@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 18 May 2026 20:34:22 +0200 Stefano Brivio wrote: > Stefano Brivio (2): > tcp: Don't accept data when socket is in repair mode Not sure Eric is on board with this patch in the first place. Sound like it's not the intended use case for REPAIR so IMO it's up to TCP maintainers whether we want to support this. And it's definitely not a Fix. > selftests: Add data path tests for TCP_REPAIR mode Please don't add a new target, fold it under net. Targets are a PITA to deal with in kselftests.