From: Qingfang Deng <qingfang.deng@linux.dev>
To: David Yang <mmyangfl@gmail.com>
Cc: hong son Nguyen <hongson.hn@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: yt921x: Add ACL support
Date: Wed, 20 May 2026 11:08:02 +0800 [thread overview]
Message-ID: <20260520030803.1615-1-qingfang.deng@linux.dev> (raw)
In-Reply-To: <20260520022242.120640-1-mmyangfl@gmail.com>
On Wed, 20 May 2026 at 10:22:36 +0800, David Yang wrote:
> Enable filtering of incoming traffics. Note that custom filters are yet
> to be utilized, and thus not all flow dissectors are implemented.
>
> Tested-by: hong son Nguyen <hongson.hn@gmail.com>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> v1: https://lore.kernel.org/r/20260514192140.3468543-1-mmyangfl@gmail.com
> - fix issue reported by test robot
The always-false comparison is still there:
> + if (match.mask->ip_proto) {
> + enum yt921x_l4_type type = YT921X_L4_TYPE_OTHER;
> +
> + if (match.mask->ip_proto == ~0)
../drivers/net/dsa/yt921x.c:1821:29: warning: result of comparison of constant -1 with expression of type 'u8' (aka 'unsigned char') is always false [-Wtautological-constant-out-of-range-compare]
1821 | if (match.mask->ip_proto == ~0)
| ~~~~~~~~~~~~~~~~~~~~ ^ ~~
1 warning generated.
> + switch (match.key->ip_proto) {
> + case IPPROTO_TCP:
> + type = YT921X_L4_TYPE_TCP;
next prev parent reply other threads:[~2026-05-20 3:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 2:22 [PATCH net-next v2] net: dsa: yt921x: Add ACL support David Yang
2026-05-20 3:08 ` Qingfang Deng [this message]
2026-05-20 3:09 ` David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520030803.1615-1-qingfang.deng@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hongson.hn@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox