From: Minda Chen <minda.chen@starfivetech.com>
To: Frank <Frank.Sae@motor-comm.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Minda Chen <minda.chen@starfivetech.com>
Subject: [net-next v4 2/3] net: motorcomm: phy: set drive strength in YT8531s RGMII
Date: Wed, 20 May 2026 18:13:09 +0800 [thread overview]
Message-ID: <20260520101310.128969-3-minda.chen@starfivetech.com> (raw)
In-Reply-To: <20260520101310.128969-1-minda.chen@starfivetech.com>
Set RXD and RX CLK pin drive strength while in YT8531s connect
with RGMII. Need to check 8531s PHY ID because 8521 and 8531s
pin drive strength is different, 8521 can not call
yt8531_set_ds().
Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
---
drivers/net/phy/motorcomm.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index 688679457ef9..3977ec5e45f7 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -1697,6 +1697,11 @@ static int yt8521_config_init(struct phy_device *phydev)
if (ret < 0)
goto err_restore_page;
}
+
+ if (phy_interface_is_rgmii(phydev) &&
+ (phydev->drv->phy_id == PHY_ID_YT8531S))
+ ret = yt8531_set_ds(phydev);
+
err_restore_page:
return phy_restore_page(phydev, old_page, ret);
}
--
2.17.1
next prev parent reply other threads:[~2026-05-20 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 10:13 [net-next v4 0/3] Add motorcomm 8531s set ds func and 8522 driver Minda Chen
2026-05-20 10:13 ` [net-next v4 1/3] net: phy: motorcomm: move mdio lock out from yt8531_set_ds() Minda Chen
2026-05-20 15:12 ` Andrew Lunn
2026-05-20 10:13 ` Minda Chen [this message]
2026-05-20 15:17 ` [net-next v4 2/3] net: motorcomm: phy: set drive strength in YT8531s RGMII Andrew Lunn
2026-05-20 10:13 ` [net-next v4 3/3] net: phy: motorcomm: Add YT8522 100M RMII PHY support Minda Chen
2026-05-20 15:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520101310.128969-3-minda.chen@starfivetech.com \
--to=minda.chen@starfivetech.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox