From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466373B892D for ; Wed, 20 May 2026 22:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779314722; cv=none; b=Q3b3qig70DuIyRufC+5NnMVeNfBoYQoPLWou3NH76dC5Rc9wu+agvoabEIZ7UgFjb1yRnFFRmYEq8Pzbtz0sBDfm3Enngj3a9HteP2KRyjJ7cGaoS4/ombvPXjf5HwkPydH/bTcxW7g3jqN9Afex69RaVCsCKWZJWwH07mQwCzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779314722; c=relaxed/simple; bh=EAHj+kn6zB+s9R9kYRpAYo5FWjV8HrADCmvZWmSfGnM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=frvi3huXGr5zyC34/OhqLgYw2EWPLoyDouovQyZpMUJdwLo7dEwEOMTtgkGAdrIQtB/l0TBgwPMRYzjgEV75N6oFpS7YJl2RZ+hCWbvomsVlBvF54l7tcnZJ/S7cJCNmXrWdhSaHiIpOqdsBhPj4ZH+Gk3s1m/02Ez1B8y0AM5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K+IBJMrN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K+IBJMrN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 355C71F000E9; Wed, 20 May 2026 22:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779314719; bh=G1PwypRSKkHU7CNvvo+j/kzpCpTnWOTagmLtKbZfVNk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=K+IBJMrNxPlSbXrOGEQjMcu3pgfL385kGkvyiO9VffK78DnuQPiDQ5+Q+5VyaAS6+ TybYAz2TS4QDvl9XQn6vdyYVYLig8/STJnJjOyyOfcdKMZbjkhzhz1alYEa08Vi7EN bGvd3cij1+eiTsluN1c3/yBBGw1++w4dvLFyHm+OK9hAFSFpWnV++QGI9V3ZwmzEFi Ww4nTlcU6iSxhPChDLvwBges7+4rRM7/ucWAncsJJVXq5UHaORu/TnacSwxZeXT0U4 7pp02nb7ep1yQ70GkYmCM/p3kHlFMRNm7PWMTLPc7RKtG8E+ukrCrEF6Kkwl/Hzr2W 82JBh5j3saO/w== Date: Wed, 20 May 2026 15:05:18 -0700 From: Jakub Kicinski To: Gal Pressman Cc: Willem de Bruijn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , netdev@vger.kernel.org, Simon Horman , Dragos Tatulea , Alice Mikityanska , Matthew Schwartz Subject: Re: [PATCH net v2 2/2] udp: Fix UDP length on last GSO_PARTIAL segment Message-ID: <20260520150518.2e65eb26@kernel.org> In-Reply-To: References: <20260518062250.3019914-1-gal@nvidia.com> <20260518062250.3019914-3-gal@nvidia.com> <20260519181200.323fbaef@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 May 2026 19:34:17 +0300 Gal Pressman wrote: > On 20/05/2026 4:12, Jakub Kicinski wrote: > > On Mon, 18 May 2026 09:22:50 +0300 Gal Pressman wrote: > >> + if (!skb_is_gso(seg)) > >> + /* last packet can be partial gso_size, account for that in > >> + * checksum. > >> + */ > > > > No need to repost but I think we should tweak this comment. > > Saying "partial gso_size" when it such segment is in fact > > not part of GSO_PARTIAL is a bit confusing. How about: > > > > /* Unless skb fits perfectly as GSO_PARTIAL, the trailing > > * segment may not be full MSS, account for that in the checksum > > */ > > > > ? > > Sounds good, should I submit a patch? I'll edit, don't want it to miss the PR