From: Jakub Kicinski <kuba@kernel.org>
To: Weiming Shi <bestswngs@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Xiang Mei <xmei5@asu.edu>
Subject: Re: [PATCH net v2] net: team: fix NULL pointer dereference in team_xmit during mode change
Date: Wed, 20 May 2026 15:20:18 -0700 [thread overview]
Message-ID: <20260520152018.1098f9ed@kernel.org> (raw)
In-Reply-To: <ag1PTfcsbowK68g5@Air.local>
On Wed, 20 May 2026 14:14:10 +0800 Weiming Shi wrote:
> > From looking at the repro it seems like you never add any ports?
> > I suspect that the author of this code assumed that if there are
> > no ports there must be no traffic, so it's safe to be flipping the
> > modes. I'd rather prevent the race than make it safe. Could we defer
> > setting the real handler until after the first port is added?
>
> The next version will drops the release/acquire and replaces memset/memcpy
> with per-field updates that skip transmit/receive entirely. They stay as dummies
> throughout mode change since team_adjust_ops() already handles them based on port count.
> WRITE_ONCE/READ_ONCE for tearing, synchronize_net() before exit_op() to drain old readers.
>
> Does that match what you had in mind, or would you prefer a different structure?
Please post it and we'll take it from there
next prev parent reply other threads:[~2026-05-20 22:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 18:18 [PATCH net v2] net: team: fix NULL pointer dereference in team_xmit during mode change Weiming Shi
2026-05-10 15:25 ` Jakub Kicinski
2026-05-10 16:06 ` Weiming Shi
2026-05-10 16:59 ` Jakub Kicinski
2026-05-18 9:51 ` Weiming Shi
2026-05-18 21:22 ` Jakub Kicinski
2026-05-19 8:51 ` Weiming Shi
2026-05-19 23:21 ` Jakub Kicinski
2026-05-20 6:14 ` Weiming Shi
2026-05-20 22:20 ` Jakub Kicinski [this message]
2026-05-19 8:57 ` Weiming Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520152018.1098f9ed@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bestswngs@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox