Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH 4/7] net: arcnet: expand unnecessary I/O abstraction macros
Date: Wed, 20 May 2026 15:23:30 -0700	[thread overview]
Message-ID: <20260520152330.699e2ee7@kernel.org> (raw)
In-Reply-To: <CADkSEUhXU7f+k+yBO2Y=eonch2k7YmwbQe6o9RP9osRoo1KFBA@mail.gmail.com>

On Mon, 18 May 2026 19:21:05 -0700 Ethan Nelson-Moore wrote:
> On Mon, May 18, 2026 at 6:22 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Sun, 17 May 2026 18:07:24 -0700 Ethan Nelson-Moore wrote:  
> > > Now that the BUS_ALIGN variable has been removed, the
> > > arcnet_in/out/read/write* macros behave identically to the functions
> > > they wrap. Expand them and remove their definitions to make the code
> > > easier to maintain.  
> >
> > This one reportedly transiently breaks the build.  
> 
> This is due to incorrect patch ordering on my part - if you apply the
> ISA/PCMCIA removal patch before the two I/O abstraction cleanup
> commits, the code compiles after every patch.
> i.e., use this patch order: 1 2 5 3 4 6 7

FWIW we're expecting repost, we can't fix the ordering on our end
to re-feed all the CIs. Build breakage prevents any deeper testing
from kicking off.

I'm writing for another reaons tho - I've been meaning to ask whether
you know of any reason to keep arcnet in tree in the first place?
We can start with this series, mostly asking about next steps
'cause some are posting fixes for arcnet and I'd rather delete it
than spend time making sense of this ancient unsafe code :/

  reply	other threads:[~2026-05-20 22:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260518010739.80979-1-enelsonmoore@gmail.com>
2026-05-18  1:07 ` [PATCH RESEND 1/7] net: arcnet: com20020: remove misleading references to multicast Ethan Nelson-Moore
2026-05-19  1:32   ` [PATCH RESEND 0/7] ARCnet: remove outdated drivers and information and unused code; small cleanups and documentation improvements Ethan Nelson-Moore
2026-05-18  1:07 ` [PATCH RESEND 2/7] net: arcnet: fix typos in comments Ethan Nelson-Moore
2026-05-18  1:07 ` [PATCH RESEND 3/7] net: arcnet: remove code depending on nonexistent config option Ethan Nelson-Moore
2026-05-18  1:07 ` [PATCH 4/7] net: arcnet: expand unnecessary I/O abstraction macros Ethan Nelson-Moore
2026-05-19  1:22   ` Jakub Kicinski
2026-05-19  1:29     ` Ethan Nelson-Moore
2026-05-19  2:21     ` Ethan Nelson-Moore
2026-05-20 22:23       ` Jakub Kicinski [this message]
2026-05-21  0:46         ` Ethan Nelson-Moore
2026-05-21  1:54           ` Jakub Kicinski
2026-05-18  1:07 ` [PATCH 5/7] net: arcnet: remove ISA and PCMCIA support; modernize documentation Ethan Nelson-Moore
2026-05-18  1:07 ` [PATCH 6/7] docs: net: arcnet: remove outdated/irrelevant information; improve style Ethan Nelson-Moore
2026-05-18  1:07 ` [PATCH 7/7] net: arcnet: com20020-pci: avoid -Wformat-truncation warning Ethan Nelson-Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260520152330.699e2ee7@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=enelsonmoore@gmail.com \
    --cc=m.grzeschik@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox