From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 209D1371CE3; Wed, 20 May 2026 22:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779316386; cv=none; b=pgGm5cx5Hhkles3Mo8nnM6DNVg0JtfhwhyfJnLuzZnqHSTOglK1tdKX1kwVOe3XO3aUbCqsW7JqLVZEczd4ulZtcPbx2tCRBGANzmgGmN44b7YGMKNO0WODXymEY4uQwnlLtfihncSX2Tt57Ck0abh+lfk7CWT0Vm+3yIqikZ5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779316386; c=relaxed/simple; bh=FXwEtPiTtY8NnrFt8WmwY1onC4xP3QHCk+kOM0E5nEQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MDvKUvEHvTJIULMdvQIWRgxbHmQ2uge3gAxNuIAASecQHvvZQf6qzZaap1YecpAH+1qzFzWNg9Gnf2iam1cCWakdCmE30MblUpeDkti+URz1DJscK+4HJZ7TqTU8KToD7DswyWusbDayCZ0mbJD1Z23f4zMoqH//5VqY0FFwFtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b+RnrgCF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b+RnrgCF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A5E41F000E9; Wed, 20 May 2026 22:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779316384; bh=FXwEtPiTtY8NnrFt8WmwY1onC4xP3QHCk+kOM0E5nEQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=b+RnrgCFsTXY6uym5xJad7XUGGEIMm+gTEU8fuATtNAN7vXektT7sHTbgaNkvrHus LhVIWiO2yLloZFkRrh/GQVtProC8rdH00ky522apmnNMrWL5typwVNPQ/Cnr89CJf2 ROy29UJLg7ANFSWQhLPrFcmxCIN1nUB/SjG57PZUJ08I4ZoxZP420xXJWqeczG2G1v o8G4dO5Fk62TN1elbpRPS8ccZC/rWTLLpQktPcLKJ5rJD/Bacf43CH4xgmwwVlXjX7 DfQHBY0LFlvU9w6wTFV5kYKj2XhMxDXX/z1wVMQvx/+0zSwwuG5IBz7Spm6dB1tyc0 ehpwgfa+Zn03Q== Date: Wed, 20 May 2026 15:33:03 -0700 From: Jakub Kicinski To: MD Danish Anwar Cc: Luka Gejak , Felix Maurer , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Roger Quadros , Andrew Lunn , Meghana Malladi , Jacob Keller , David Carlier , Vadim Fedorenko , Kevin Hao , , , , , Vladimir Oltean Subject: Re: [PATCH net-next v2 2/2] net: ti: icssg: Add HSR and LRE PA statistics Message-ID: <20260520153303.33692fe3@kernel.org> In-Reply-To: <1d8ab51a-6943-4978-88cf-adda8cc57f7e@ti.com> References: <20260514075605.850674-1-danishanwar@ti.com> <20260514075605.850674-3-danishanwar@ti.com> <20260518184506.694c584e@kernel.org> <20260519165646.09b0783f@kernel.org> <1d8ab51a-6943-4978-88cf-adda8cc57f7e@ti.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 May 2026 15:30:24 +0530 MD Danish Anwar wrote: > What should be the next steps here? Is there any existing defined set of > stats where I could populate stats from ICSSG firmware for HSR (similar > to ndo_get_stats64 callback). Or de we need to implement a new callback > that will do this for HSR. I'd try to plumb this thru ndo_get_offload_stats Close enough for my taste, let's see if anyone objects. > I agree with Luka on the categorization, Felix responded with the MIB counters which are even better. We should probably define a struct with all of those and then just fill in the ones you have. Please do the same thing ethtool Netlink does, break the counters up, each member to its own Netlink attr, in the kernel init them to ~0 and only report values the driver actually set to something. We don't want to print 0 for stats driver doesn't support.