From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386F0257459; Thu, 21 May 2026 00:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779324351; cv=none; b=BA+P8IAThWyA0kgPoG58RyZ+dTCxdTIhDkLj51GneC5CLheXtw7zv7IYOgOJfH/KfObCh/HGtHJQQOffRj4HGeD+Ay7BEW6lWdUXsAQJB7VEPNj+AxQsHJToZvOCL9RDc+BxC9GY0XNBKjqGJ6MIKP3hTSd26C7wTCA/FJPMCYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779324351; c=relaxed/simple; bh=B/ZeesevxXHRQd2uEWIIOWvHeWpFAm1kO/+BiHAqmnA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u/Uy+Z4N5JdIrCHNU9eP+dHYW3cKvQhbyxrqNRd+Yn8VwNM7yQiDwYUT+o9qJHmgYbBfIU1lyZJBB1rL/hMtHr/j5YlGP64QB/uwy+nCgcwDNkwBpIReGh00SQ2YADfz95rd+X88HupSrZz0CT984KFk/Iclr3lz1oqoY8jvdd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RLpc4G+R; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RLpc4G+R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FBA51F000E9; Thu, 21 May 2026 00:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779324346; bh=d/GjZWbX9fuiG28r9u5wb4+qykcdkLHar6zri5fQxHM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=RLpc4G+RqTO3RNeHjmqFeFE4bAmLfOaNRO/Qau/Y9ZFbMqKQVkXVg5k4L1YGNHqwB qmcqUl/cjm5QcA8RUa92cKkvZfTLk9XY0wrblhcjKyi1BbKfCfuqhSb42WbOyUuJcO oWL3h2EHZTvHSqOMjXlRWjkXM/rwk6abKxcpabpD+YBuw78dDnxFW2zcHAZO+FDiNr aecYjPKIgXSfa6gOkcGEJBDvISX2M05D+1IJKJRDJZzuq5izRhRLHaTHOt3Aot+CMZ 9hQbKWO14EqyrG7CnBuKvVFbdLkorew+LxX/4vsQfdWh5kn9L5QXCpxXHMoTCXBL9v x2LyOwzxnQ8CQ== Date: Wed, 20 May 2026 17:45:45 -0700 From: Jakub Kicinski To: Rosen Penev Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , "open list:FREESCALE QUICC ENGINE UCC ETHERNET DRIVER" , open list Subject: Re: [PATCH net-next] net: ucc_geth: Batch RX packets before stack handoff Message-ID: <20260520174545.69766438@kernel.org> In-Reply-To: References: <20260517192856.3925-1-rosenp@gmail.com> <20260520165746.7ed10c7b@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 May 2026 17:39:41 -0700 Rosen Penev wrote: > > On Sun, 17 May 2026 12:28:56 -0700 Rosen Penev wrote: > > > Collect received skbs on a local list during RX polling and pass the > > > completed batch to netif_receive_skb_list(). This lets the networking > > > stack process packets from a poll cycle in bulk instead of handing each > > > skb up individually. > > > > GRO should be even better. > GRO will result in slower routing performance because there is no > hardware checksum. Mention this in the commit message too. Network adapters without checksum offload are pretty rare these days. Speaking of being old, do you know if this driver is used in practice? Maybe we can delete it.