From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7E9C3F39EE for ; Wed, 20 May 2026 18:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302287; cv=none; b=DwHe4ni2DDW09iyIrqx1Rq9cpVRXFieMeW7oJtKpoJUJ31eA0HCS/doJGr74HqzI38299ePfl/C4q+OB5ER8coXoSZ78nssF4AU8A3Km90kVkqadFfWfZKDVGWvu/4WCeJDxVDgsDY8PruFf7NvqqTv2ANDaHjsdBabNpkMbkA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302287; c=relaxed/simple; bh=oiDmDzRlvpUWP3j3IZra960yjAD9qjRZTM8+sInDwl4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oqr+9JgPAwG41hudKoi3rShJfc9g0sedrsPufWOE0Ks960ByQsn+T/220/5OAxzRC7hhTYmH9cwHRmOhr/s/0/vZhKG8blNLYuWiSWbyufFi/D4WUiIG/4yrIkHSA6JM/ICXQkKOZCQNUY6NsbSCEhtf1nRheX38TEOQ007v3qU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oPy9Gp62; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oPy9Gp62" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25D661F000E9; Wed, 20 May 2026 18:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779302285; bh=Vli160Be25ufAg5UH9YxzHJ/rgEgzlQQ8hmf32U8RDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oPy9Gp62SyYkWC9q0Pwf85qOMAwbN/7sf54xlrfeKS+OI32FRNd2lllcORwt35a1o qzdB3Le0JFXjqfMBrhuZ97JU5avCMKa+K287iMNzRZEzgFKvi1V8lkqC3BT+ODgqlF mDjzpe3Ts9qU7WtysPE8G/6dLi/DqV7OLXxYNz/VrbxHC+QItZUhC5neBwxswCAZcC 3dUbtQ4hhaivh7OwosRe/zoqxoeTgXf6KxwGiCYQhKzS0k0U/OB5hnUmGvIAD1446P Y3/M+UDIdYre6x1qW5nSDZHsrExexnJXP+BBnqHubQTVfJA/P2xC6jYchmveLSB7rB z6SKBWLsaoNEQ== Date: Wed, 20 May 2026 19:38:01 +0100 From: Simon Horman To: Przemyslaw Korba Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, aleksandr.loktionov@intel.com, arkadiusz.kubalewski@intel.com Subject: Re: [PATCH iwl-net v2] ice: suppress DPLL errors during reset recovery Message-ID: <20260520183801.GE988238@horms.kernel.org> References: <20260520115213.10864-2-przemyslaw.korba@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520115213.10864-2-przemyslaw.korba@intel.com> On Wed, May 20, 2026 at 01:50:06PM +0200, Przemyslaw Korba wrote: > During reset recovery, the admin queue returns EBUSY which is expected > behavior. However, the DPLL subsystem was logging these as errors and > incrementing the error counter, potentially leading to unnecessary > warnings and even disabling the DPLL periodic worker if the threshold > was reached. > > Suppress error logging and error counter increments when the admin > queue returns EBUSY, as this is expected during reset recovery and > not a real failure condition. > > test case: > - ethtool --reset eth3 irq-shared dma-shared filter-shared offload-shared > mac-shared phy-shared ram-shared > - observe if dmesg EBUSY errors are gone > > Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu") > Signed-off-by: Przemyslaw Korba > --- > v2: > add missing EBUSY check in ice_dpll_pps_update_phase_offsets() > v1: > https://lore.kernel.org/intel-wired-lan/20260520105311.5336-1-przemyslaw.korba@intel.com/T/#u Thanks for the update.