From: Simon Horman <horms@kernel.org>
To: Przemyslaw Korba <przemyslaw.korba@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
aleksandr.loktionov@intel.com, arkadiusz.kubalewski@intel.com
Subject: Re: [PATCH iwl-net v2] ice: suppress DPLL errors during reset recovery
Date: Wed, 20 May 2026 19:39:28 +0100 [thread overview]
Message-ID: <20260520183928.GF988238@horms.kernel.org> (raw)
In-Reply-To: <20260520183801.GE988238@horms.kernel.org>
On Wed, May 20, 2026 at 07:38:05PM +0100, Simon Horman wrote:
> On Wed, May 20, 2026 at 01:50:06PM +0200, Przemyslaw Korba wrote:
> > During reset recovery, the admin queue returns EBUSY which is expected
> > behavior. However, the DPLL subsystem was logging these as errors and
> > incrementing the error counter, potentially leading to unnecessary
> > warnings and even disabling the DPLL periodic worker if the threshold
> > was reached.
> >
> > Suppress error logging and error counter increments when the admin
> > queue returns EBUSY, as this is expected during reset recovery and
> > not a real failure condition.
> >
> > test case:
> > - ethtool --reset eth3 irq-shared dma-shared filter-shared offload-shared
> > mac-shared phy-shared ram-shared
> > - observe if dmesg EBUSY errors are gone
> >
> > Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu")
> > Signed-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com>
> > ---
> > v2:
> > add missing EBUSY check in ice_dpll_pps_update_phase_offsets()
> > v1:
> > https://lore.kernel.org/intel-wired-lan/20260520105311.5336-1-przemyslaw.korba@intel.com/T/#u
>
> Thanks for the update.
Sorry, hit send too soon.
I meant to also include:
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-05-20 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 11:50 [PATCH iwl-net v2] ice: suppress DPLL errors during reset recovery Przemyslaw Korba
2026-05-20 18:38 ` Simon Horman
2026-05-20 18:39 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520183928.GF988238@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=przemyslaw.korba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox