From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 024A8395AE6 for ; Thu, 21 May 2026 08:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352644; cv=none; b=VSEzWGm5xqcoKujhb4e6pIXlWbHeu3QIT5b1lm0WRhE5huAuQqhCLDTxGm/kbH4gaNghMwVLen3iUhpLd/I08qGd3/8Qwi08jlAAVp8LEneynGpLlcVRRog8R1nasQBUoOBYUOlyRqDc/URQn6etcDS7R+ELHjR6a8sNUdjIksA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352644; c=relaxed/simple; bh=S6soBSVe9KjUpY4fV3w6m8V++eYkYCwWMWeUkaW05Ts=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nVZijjZMvrYib9ay1IxtabG4CMtVItPbHOBqmq6mu6wN62bD89ti2LUlnQsyKtLL8ak5UItO07ErW4QT+dxIfsSgFqI/18zoxNqIioxIWQBT9Ox+6E1HIF95zZBBXnvianM5V8iV594EPnxY8HMXHGSKbSzy0YBvrnh3rdwqwos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=djQmFj4O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=krRQfHSC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="djQmFj4O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="krRQfHSC" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L8SVhn748558 for ; Thu, 21 May 2026 08:37:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7/ctKXvDvcUgQZW7V3LpqjnLay8t9Q9hc/bk2yC/dt4=; b=djQmFj4O78Kw61Af ZTRwyYsSq1FlwApquXAjrrMNV6MDYgIBSnNZiRtCqTVIosmFcxjAkb1ty/75WjCK YhtUfvmst1pJLM3GcrvSe0ezIW7Y50K4lTYcWo33TJohgKYVSUOZ+WkqzTwOCbCo gSbIPnGGTI5VqDzxpucso1RxtjGPhan9P3mqO4xk4xxPWE95nTbckAEOX/Nhkh6A zpCTWRZMwjoYJuZP0mtrLG2RWeFPWj/XrmkVB+nJYoKeg7L7a3JorUpO1077eV9g V9PdzC9QKLJxRsQUorxPcY9EMEzc++ifXfG4xJzguDOQbn218aeX2vyAagWRixO5 w5qyzg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9fb6kj5j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 08:37:20 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-516879bf1a7so158277231cf.1 for ; Thu, 21 May 2026 01:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779352640; x=1779957440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7/ctKXvDvcUgQZW7V3LpqjnLay8t9Q9hc/bk2yC/dt4=; b=krRQfHSCdA1t9uDEfc5mroC6h2SqdB/L0pYCgMw86HBgrlaWDxm1IQBKtyP1Eq1kB7 NJ3Cjb6e7vTd9G0NrFM+UtTs/FGiiC7i9+ukZ9DTW3jfJo05apVZSPOzgt2aET0FWVcj JJSCqLs21yx+zZPAdlPsXtghKN/fUHXO6Ld7WgPYohyuCL3mvxOTfvscuzLsYjbjOJtM wcTQ3Uv4dn8Be8BmiiuexKVS+KHzexL0S90q8NakyIDD42d8jOoMJKndOqdg38BDgc86 GqK0NcfTOSSu6KFIFGIwxgeJYgnE2jgYQvFkwk65431wNX4dgmyfmfhcQ17VS7C+WEy8 6VWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779352640; x=1779957440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7/ctKXvDvcUgQZW7V3LpqjnLay8t9Q9hc/bk2yC/dt4=; b=PXZtjUDfB4ah3tMox1GJnj7d4rn8Po/NiBn2pKqdhf2s8P6XKYgKZMEbSMgN1XJ+qe Vs9jDxktjxW7brUN0d0301UOqBk7wSqo4iginjYLtiQ5BQgZ3honBQ1OMDE4UoAjEEPh vVuJ4UCmAyxOfQUKb8Xn62BHXodZ4xSaAApfa0RjTa0IepAWMtmvOMI5dBpBv8yF0QJ2 uOHfwFJbI3fwPRI5QvpNLBte/iOueAj37eSQluH6vwcEljmQHQzvx7P32kINEQKGojhZ G581GkA1gX47XAcHR+ropR5SSUZyL1TfPhIKtOE+SShICezE9IeQW79zlFxSjGww5Xj4 ebnQ== X-Forwarded-Encrypted: i=1; AFNElJ8U6tnPZvTQsjKhJPwwe1df53gOMGXAzdulVs4zf5Yt9f5GYRk3lPbgU07dwvMXQqrpbE6c02w=@vger.kernel.org X-Gm-Message-State: AOJu0YyMfP2yyh6jmQDbWSQIqTnV4S9DlvVA5dQeePWyxWhVN1gIjXhb 3+JrUtzoG0sGOgO2a/M4UIlbGH9uWFIPmNkGC9o9aWtkLfU0DTJQJlTg8KWG8uIGJuli9Jxgdxb 6lLVQGkMWPEHl6A2/1Unyjk6nF8lZItq7PjlPDQiw9os099wt6eje9a4nZmI= X-Gm-Gg: Acq92OFoEvI86X3FhIcMmMVnWSlcUapXJx9WB8E+CN9pP+r+2NRvYNBW8j9E171NACo 6fPJwc+RE0tX4eY019G5pk9hHYodTpv26Vxsd35q1d9eTAAn2eXGdgfvPeoQ9VmUwgDkj/KfVEm jCsCJh/JXPUVviQyX85KD3OBguIQw095ikyg21aR0WzpI9CUS3p5HHM104Pf/W4SYfpLt886EkJ XbNJ6jPlodHidW5r7kOxS7TCpZ5h2uvGT/6LEPIyBPZjVMHTtZCfOhwzd7CJ2DDnflwstm+h8rr vZUoKp38656pH0ETwXOUD3ZuuOO6TmJQI6Ztaq3sfDNN8OOam7JW8j8HF2eCqMkmnNgaf5cgoxj ppTe70gHkYRpxLhE77M6BnmYI3lNnv1ZWiS72+VYKKeD2mLuaDLQ= X-Received: by 2002:a05:622a:8356:b0:516:7a83:8c37 with SMTP id d75a77b69052e-516c551754bmr17064441cf.11.1779352639547; Thu, 21 May 2026 01:37:19 -0700 (PDT) X-Received: by 2002:a05:622a:8356:b0:516:7a83:8c37 with SMTP id d75a77b69052e-516c551754bmr17063841cf.11.1779352638906; Thu, 21 May 2026 01:37:18 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903caede9fsm10502405e9.14.2026.05.21.01.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 01:37:18 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 10:36:27 +0200 Subject: [PATCH 04/23] pmdomain: imx: fix OF node refcount Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260521-pdev-fwnode-ref-v1-4-88c324a1b8d2@oss.qualcomm.com> References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> In-Reply-To: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> To: Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Andy Shevchenko , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt Cc: brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1152; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=S6soBSVe9KjUpY4fV3w6m8V++eYkYCwWMWeUkaW05Ts=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDsQhtpU/CqYzAaq1jp+LLLiJjIA5Qt/YY/0VT S3IUh2uDoyJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag7EIQAKCRAFnS7L/zaE w1etD/4l9O7wUTmpxjRT+gvruneHUxzYHEIhXscwzHkmXXFaTqlBavoUQKz+sPAmBcudjOXscQZ mu4A2CkrCOVZtrepbcDAksLfqo0RIXfw8xZ6iNAc7TSbIK3BuxmxPm9SM9FrlfFCYlcXIlQCPU3 VVJ56YN3+53SSoxDlaWqJqOl01UWof5ledWKTH8dzoqTxaxB+LlTLL2+tl6wzT1hIGLaHrq0NHx bCcVpM4BywkAyrn1olQuZt9D+PmGCR/zu4IqxjWNsg1Ik47sX+JWSrJCCDlVs9WzwSP6edRFsTr eWVh9X/z0Zp1hPf5XkuxC8WEE+ciQUi1ZtOFxOUY3Vjfup0mR2EWcJYYwcvH85XbmRz/VZugYMl LhAXbqUdasak8C0n65UmlfBHkKOBeIwN23suD7Yx+Q0ORyAUBdEQEp4N7QpNWQpHLr+upEQjLOY 2MWtqbCVH++FysZ9T8ZwTwT0ndcQDFCyMi2V3eXQjB7KVSGpXFzWPg/SFqJSbL97xhV84W6Izaz hKCOM+EEUU296NZs3+u5L2wPfjObJIqYpxM9fKJuc1oRI1cjHoUUBAbdGLhOXXnN62XXTsUqhLm zCKbcupHSwPo+aF8UgCOTdYr82ZFVr+ZBQa5PZBJSIY2Wd4qB0rRonQwRh/TRYIARXk9niYp7WR TMEzEazWVqpnxdg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=do/rzVg4 c=1 sm=1 tr=0 ts=6a0ec440 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=3puIpDhKG-71yv69WsIA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: j38LNzJh4Y02rMB9bAn8q3RoG3T26QJU X-Proofpoint-GUID: j38LNzJh4Y02rMB9bAn8q3RoG3T26QJU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA4MyBTYWx0ZWRfX29AT9MrYueoW D182erw+2qT5OhEsHCfRL8SI6wds/8dOam9dJ/q93vp3wqTqn2WBLst3+HJmEtDdJ7hS8+MUmC7 AuwiL58VH3dNqyPt6ywrUfFhCSYGdfyWJQAU8QltmcOOTQ0E4+6WlzczHzCXJVkO6YwpEF5vBxa UnAvIQukePXiZ5E8i20o9SbFQaLLt/vHbw8TSu4QgySL2W4onlOt8Kfh0cgLM5ROvK+EX9ICb0/ seMGsgbW6x1AiABK0NWoPW44RQdWEVhooC9Ja285R4gMyJO/pdANVBMCVsrkvAd7JTCsb8fy82R nBf1OJQn/KB+MI3i92Akv8ZrZyfmSYgd92a1HaZrPoROiPC5aWeQ5fbJZIHoTi99uPBBRPXBhII RjueRallahCqbI8ITHMFYpgQmX74C8PyHiorqbD7dXiJImR2dAKPgnakcVJv5P2mftgYmMAaoqk /pZeRh7xNIJQ+rY6aYw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210083 for_each_child_of_node_scoped() decrements the reference count of the nod after each iteration. Assigning it without incrementing the refcount to a dynamically allocated platform device will result in a double put in platform_device_release(). Add the missing call to of_node_get(). Cc: stable@vger.kernel.org Fixes: 3e4d109ee8fc ("pmdomain: imx: gpc: Simplify with scoped for each OF child loop") Signed-off-by: Bartosz Golaszewski --- drivers/pmdomain/imx/gpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pmdomain/imx/gpc.c b/drivers/pmdomain/imx/gpc.c index de695f1944ab31de3d37ce8000d0c577579d64f9..42e50c9b4fb9ffb96a20a462d4eb5168942a893c 100644 --- a/drivers/pmdomain/imx/gpc.c +++ b/drivers/pmdomain/imx/gpc.c @@ -487,7 +487,7 @@ static int imx_gpc_probe(struct platform_device *pdev) domain->ipg_rate_mhz = ipg_rate_mhz; pd_pdev->dev.parent = &pdev->dev; - pd_pdev->dev.of_node = np; + pd_pdev->dev.of_node = of_node_get(np); pd_pdev->dev.fwnode = of_fwnode_handle(np); ret = platform_device_add(pd_pdev); -- 2.47.3