From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 757EB13A3F7 for ; Thu, 21 May 2026 15:37:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377843; cv=none; b=Ayj/QC/NI+EXIF9h53q9nuG8okqOKL4UhYmhJa8GcS2ffpXNVwdKH2iHugQu+MBXcIBsnK3pt+JSgXm2PtNHZeqYd3mJMV+Wj4biM02Vsm7u1dGhRIlOk7tuyLwfticaAClkWo8Sww9OMXFmzGGqoK3yHiIx2bz8wZzS/pC9Cj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377843; c=relaxed/simple; bh=VXOwYWX1xh9f7vfOxrTrZ9VWbfBjIvmBbptxVXN1+gQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vtr/dNq1wjDNtehdFyqSC31V2BWLJ1zeg2ydH7kUsUHhnRh3q1UkIu3hIjuugz1zsoSw5BDMClrHPFrn5eE0Nw9TBujPAA2Dq7XlKFvE4qE6Uf0LJdczKjCH2sEA3eA9Fb5alD4D1kuZ5LBzIyA8HTOe4NeiSp6peVbjPpnYAvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ja8dkwva; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ja8dkwva" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD0361F000E9; Thu, 21 May 2026 15:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779377842; bh=DeqdQCLUsjvjeynVPJcNzG3Q21M+KygIZErHrc8JodQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Ja8dkwvaZr24Z4cr/C1nPi4Tog3LkboMBnczTRWyNnNoHqedX+ZXCNGliXIsnUxw6 v/kEvcz7WddwLzt5kZVkAGzGRhquxgrNEWfswHW4qLEXlmuyf9ZsgWoQ7ELW2sk/lh mkgBQiIpp9i124Rj14587MdfGcmaypi7gmP18fOhvqlxhh1XX7crx2E3QI6cQ/witV EMKY6Rig1pi9+l1BjbvKK8UmaYdqxsMTMh/3DO1nPUAztKflb2xPUhjMuwtOPbQbUm vwHzx0JXKbA6tMSgNH29VMLNk8E3lDmNaHUUf/kTYT4EXzNFmc6GoH837JzhVlm07l 82ll7i8UU/mvg== Date: Thu, 21 May 2026 08:37:20 -0700 From: Jakub Kicinski To: Tony Nguyen Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org, Kohei Enju , Simon Horman , Patryk Holda Subject: Re: [PATCH net 1/8] ice: fix UAF/NULL deref when VSI rebuild and XDP attach race Message-ID: <20260521083720.67b24a7b@kernel.org> In-Reply-To: <20260520183501.3360810-2-anthony.l.nguyen@intel.com> References: <20260520183501.3360810-1-anthony.l.nguyen@intel.com> <20260520183501.3360810-2-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 May 2026 11:34:49 -0700 Tony Nguyen wrote: > + if (test_bit(ICE_VSI_REBUILD_PENDING, vsi->state)) { > + if (prog) { > + NL_SET_ERR_MSG_MOD(extack, "VSI rebuild is pending"); > + return -EAGAIN; > + } I seem to recall complaining about this sort of error handling to you folks in the past. Chances are user space will just fail seeing this error, rather than retrying. The correct behavior would be to wait. Is that not possible? (I think Sashiko is brewing a lot of comments for this series so it won't make today's PR either way :()