From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4750D3B9D99; Thu, 21 May 2026 11:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779363820; cv=none; b=uqhf5MEANMQAmBQ/PH2qvyB29pCIFtIb8GM3WJLx0wvTLrbDKOVNQqCXkz2lvpqCX/LUHzawH62w3pHny/CyAGogMVg1G7m/hakdVrXggEFtge+HYS+UeqcB6y1G3XTuFb1CDZaETXBuB+MHRKwZBpO1lCD5+J+if3hP8JTOWkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779363820; c=relaxed/simple; bh=QOd//fO+Z95+AtVyKwYZqUD+VnOJI1Z/8+wve31LCik=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YQ8KiQuSF1hyxYFJ+IsIubt31XRJsupNfkHbtd0Nbq3WKpSeDxi/mg/B4fwYZwsfjMh2LGMuvE6Wj7wTIQ2LZvoF2Yzl/9xT5tpRPq9rKm5DMdbAj8r7as2H1FiUZSt+2clfU6FFIvjOdyfVBEuY8RR26Q3aUjVNTQVMBeB3xxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KVWGSSQk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KVWGSSQk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1384C1F000E9; Thu, 21 May 2026 11:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779363818; bh=gNwhZlZNvRf30NjRud00r64+zMtRvb84BXByEUe94wE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KVWGSSQkk7z2naqeJYJq6xHDJDJnA4c1yP3WGTzwMTrL5NehmGY25IXM4PaHiJoCq YE0sw3ITwkOvRbHQZWO83SC6dGNMEj2Iy1VHSmkGYDKstDCs35IYnLwRhAzHnLJ3dR S4yKQ0MPhoL6xXVBQ/9tGpNPgPsCIMtwHgl7pjkaxic9P1I5ZVsNNGVPkV/qcT/dec vTeUU5zXzfe6PEbTRV1jMgdWwu1K/vogJsjUrjACNhBQNNdg/YdWhHDFXXjKCGBuYN Ao2f1ASEDBeCTTaMBqIMc09I0BinuzmIroz9wyaBVfGwoa8+SAZitgo3kMfCP3qo52 XEC7f9RVp5Sjw== Date: Thu, 21 May 2026 12:43:32 +0100 From: Simon Horman To: Larysa Zaremba Cc: Tony Nguyen , intel-wired-lan@lists.osuosl.org, Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Alexander Lobakin , Aleksandr Loktionov Subject: Re: [PATCH iwl-net] ixgbe: do not configure xps for XDP queues Message-ID: <20260521114332.GC1506108@horms.kernel.org> References: <20260518111506.65284-1-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518111506.65284-1-larysa.zaremba@intel.com> On Mon, May 18, 2026 at 01:15:04PM +0200, Larysa Zaremba wrote: > netif_set_xps_queue() should not be called for an XDP Tx queue, since such > queues are not netdev-exposed. On systems with number of CPUs >=64, on E610 > adapter, netdev is configured with maximum number queue pairs being 63 > (due to MSI-X assignment), but configuring XDP results in 64 XDP queues. > > So, during XDP program load, when netif_set_xps_queue() is called for the > last XDP queue, we get a WARNING with a call trace and KASAN report > afterwards (if enabled). > > [ 2012.699800] WARNING: net/core/dev.c:2854 at __netif_set_xps_queue+0x116a/0x1e40, CPU#36: xdpsock/103668 ... > > Skip XPS configuration for XDP Tx queues. > > Fixes: 33fdc82f0883 ("ixgbe: add support for XDP_TX action") > Reviewed-by: Alexander Lobakin > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Larysa Zaremba Reviewed-by: Simon Horman