Re: [PATCH net-next v4] hsr: Allow to send a specific port and with HSR header

[kernel test robot <lkp@intel.com>]

Hi Sebastian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 9e0898f1c0f134c6bad146ca8578f73c3e40ac0a]

url:    https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/hsr-Allow-to-send-a-specific-port-and-with-HSR-header/20260515-223023
base:   9e0898f1c0f134c6bad146ca8578f73c3e40ac0a
patch link:    https://lore.kernel.org/r/20260508-hsr_ptp-v4-1-aa19aa7c6a71%40linutronix.de
patch subject: [PATCH net-next v4] hsr: Allow to send a specific port and with HSR header
config: mips-randconfig-r123-20260516 (https://download.01.org/0day-ci/archive/20260521/202605211206.puPhEK7J-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260521/202605211206.puPhEK7J-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605211206.puPhEK7J-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> net/hsr/hsr_device.c:242:42: sparse: sparse: restricted __be16 degrades to integer
>> net/hsr/hsr_device.c:243:39: sparse: sparse: restricted __be32 degrades to integer

vim +242 net/hsr/hsr_device.c

   223	
   224	static netdev_tx_t hsr_dev_xmit(struct sk_buff *skb, struct net_device *dev)
   225	{
   226		enum hsr_port_type tx_port = HSR_PT_NONE;
   227		struct hsr_priv *hsr = netdev_priv(dev);
   228		struct hsr_port *master;
   229		bool has_header = false;
   230	
   231		rcu_read_lock();
   232		master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
   233		if (!master)
   234			goto drop;
   235	
   236		skb->dev = master->dev;
   237		if (skb->len > ETH_HLEN * 2) {
   238			struct hsr_inline_header *hsr_opt;
   239	
   240			BUILD_BUG_ON(sizeof(struct hsr_inline_header) != sizeof(struct ethhdr));
   241			hsr_opt = (struct hsr_inline_header *)skb_mac_header(skb);
 > 242			if (hsr_opt->eth_type == htons(ETH_P_1588) &&
 > 243			    hsr_opt->magic == htonl(HSR_INLINE_HDR)) {
   244				has_header = hsr_opt->hsr_hdr;
   245				tx_port = hsr_opt->tx_port;
   246				if (tx_port != HSR_PT_SLAVE_A && tx_port != HSR_PT_SLAVE_B)
   247					goto drop;
   248	
   249				skb_pull(skb, sizeof(struct hsr_inline_header));
   250				if (has_header)
   251					skb_set_network_header(skb, ETH_HLEN + HSR_HLEN);
   252				else
   253					skb_set_network_header(skb, ETH_HLEN);
   254			}
   255		}
   256	
   257		skb_reset_mac_header(skb);
   258		skb_reset_mac_len(skb);
   259		spin_lock_bh(&hsr->seqnr_lock);
   260		hsr_forward_skb(skb, master, tx_port, has_header);
   261		spin_unlock_bh(&hsr->seqnr_lock);
   262		rcu_read_unlock();
   263	
   264		return NETDEV_TX_OK;
   265	drop:
   266		rcu_read_unlock();
   267		dev_core_stats_tx_dropped_inc(dev);
   268		dev_kfree_skb_any(skb);
   269		return NETDEV_TX_OK;
   270	}
   271	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki