From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21384218AC for ; Fri, 22 May 2026 15:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779464774; cv=none; b=N1AXmBAQGomhcgE5drF4QXESIzOVJQCzvoYsFH3t0ZSQcEEuGHuxyOiEoj3yxVPDTxUJEL5EUoZyvtoyzJvT5CV85hrRMA6/Ab/3blBV9YWBB1m48kO9hBUO8xL2zrpOY4g+m+yadzwknHwV1VWElGHAlGYvzz74yw/Y7i6XXsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779464774; c=relaxed/simple; bh=hx2KDFWu0T/vqnbDAwu9mZ1KWA/Wdq2y9iB7XC+O4c4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Afy/HdmC5FbO0xBvaGMq1YBrB5ZuvSMNOsTZITSSM15A2iQEn+kCbIe8uzrmKciltCpTasXSfSIcjPc3GzjHEHquYZbamRitfNgnPkYwpFYDhGjXIHp2rmFSldzF2/eusjiTC22gnqliLr/16xoTPEViRDnptIJcrcmV6TVbq6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fO4s5PrI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fO4s5PrI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11F9C1F00A3E; Fri, 22 May 2026 15:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779464772; bh=sOA1bW+w9MFq40muaJz92VaTBGym/9qUKl3E7aZi2vs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=fO4s5PrIuu1B74LiOhMZnIqwvIShhm8LFSoajTvJevhDx3hBgp81giYsQkFCIpIgt bj7yW0wWAh12CRHE322qHnkidzvhfQ//ioljVdiAPtX93yzfNYWZM+maJEX3VF6qe/ wGzSEIthm6nnk3JYDJO3A1nbYd50/bTgD/YwsCs5/srsyEnE3MjcL8nYyGFGo45HMB 9j4HWkAeIM86gcokctXFazJBT5Mqucx17Qk5I33X16CaLVbl2GNv7IbADmdlCflOMl rvTQ5YXhMFe5CYvv9ppByeW6q2Dbae8Lf/ovlVFxKx7mqfM3AH5rpVwQj5XNmqaDc2 GrhrrYBDlz7dw== Date: Fri, 22 May 2026 08:46:11 -0700 From: Jakub Kicinski To: Jamal Hadi Salim Cc: Rajat Gupta , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, jiri@resnulli.us, yimingqian591@gmail.com, keenanat2000@gmail.com, 2045gemini@gmail.com, rollkingzzc@gmail.com Subject: Re: [PATCH net] net/sched: fix pedit partial COW leading to page cache corruption Message-ID: <20260522084611.390fd0a6@kernel.org> In-Reply-To: References: <20260519033950.2037-1-rajat.gupta@oss.qualcomm.com> <20260521073526.793d30c3@kernel.org> <20260521084640.683c1ee6@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 22 May 2026 07:47:32 -0400 Jamal Hadi Salim wrote: > > > All these issues stem from the shared frags point, but the patchlet i > > > showed is unrelated to SKBFL_SHARED_FRAG, it is more related to > > > cloned+frags. > > > > Right, right. Just pointing it out cause Rajat's patch adds another > > skb_has_shared_frag(). Which we'll then have to delete in net-next :\ > > With a note that the exploits currently take advantage of that > specific cache issue. How about we allow it for net now and then > schedule a follow-up phase to remove it when you get rid of "shared > frags"? I must be missing something. What's the problem with changing the patch to pull headers instead? I mean - if we agree that this is where we'll end up - we should just do it now. It's the long standing kernel policy to "fix things right" instead of creating temporary fixes which then have to be reworked in -next