From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFEF328B7EA; Fri, 22 May 2026 15:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779465325; cv=none; b=Q/W7nWpqKsEAc+/tR88dlWfnft1lHugUNnVs9uTRbF2UQOX50UmmvnBn+UmpwBD+BFmLQRbVPOU1UZc/VvKoW5nbv1/SHuhUMujnQeZLLg+dWIcilJhvrgWJZvUQXcXsK+g/GbSaIoOgM7qkNRqyhtFwasmOiwzpr5FiR8yyuLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779465325; c=relaxed/simple; bh=p9QC77+fOS4IepZC79FvEwiT85HKsVGqeH1ixZElQSs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q14KWUOkte0qR1XzVSczeay8Zln6xCJCngTnjnKAnpRoGznNtDR5I5U0tlEdFpWGjMldUjUosY1OoqJkAQW5Ny+DnGNFsL1aQ+EiISKC7a0VNp2AdfAuGKleitZtZqMC+CFa1RaFveoTHiTic8tT8sIbyNvR2mmY+0AEiiyNCtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QnB6gVsj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QnB6gVsj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08EB61F000E9; Fri, 22 May 2026 15:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779465324; bh=vBx+xEmgiWqiT4uPnzeTJ1AxTohv1dp7pULOGoYMnlI=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=QnB6gVsjkVmFDeXnIkJg2AoGPGEvdLko479fzlLgSkENzK/cO1lIg8kip6JWm28bN 7JJIlsYkefYbqwPmlyKZMVfyXPxdmwSyhxgipsbUhjOlU3efIcOB2bEFHpHyDav7mZ 1QGOhgUD5It+R5xqlPe1j5zesmfqKh/irR178zTqlTneeAovfTXjtXpVtGqiAFDgmq fgrYYr7a7rSjr+szbPKFg6unWwYWB+ILWOxn0663jQAcIyUbpk1XSHYcQHp5ifI1Pe Q3Y1G5o8eLXDTWhozb0ndNK7Y3xqeA+A9ferSi+Mgbv3jJzNMtK72ILYM537C2kcpU 2e0d8fb794D9w== Date: Fri, 22 May 2026 08:55:23 -0700 From: Jakub Kicinski To: Ashwin Gundarapu Cc: "anthonylnguyen" , "anthony.l.nguyen@intel.com" , "andrewnetdev" , "davem" , "edumazet" , "pabeni" , "intel-wired-lan" , "netdev" , "linux-kernel" Subject: Re: [PATCH net-next] net: e100: remove redundant static variable initializations Message-ID: <20260522085523.0432a2d5@kernel.org> In-Reply-To: <19e4e74ff40.601fab765713.9212104302286035517@zohomail.in> References: <19e4e74ff40.601fab765713.9212104302286035517@zohomail.in> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 22 May 2026 12:22:30 +0530 Ashwin Gundarapu wrote: > Remove '= 0' from static variables eeprom_bad_csum_allow and use_io. > Static variables are zero-initialized by default. > > Found by checkpatch.pl Quoting documentation: Clean-up patches ~~~~~~~~~~~~~~~~ Netdev discourages patches which perform simple clean-ups, which are not in the context of other work. For example: * Addressing ``checkpatch.pl``, and other trivial coding style warnings * Addressing :ref:`Local variable ordering` issues * Conversions to device-managed APIs (``devm_`` helpers) This is because it is felt that the churn that such changes produce comes at a greater cost than the value of such clean-ups. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches