Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Minxi Hou <houminxi@gmail.com>
Cc: netdev@vger.kernel.org, donald.hunter@gmail.com,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	horms@kernel.org, aconole@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/2] Add OVS packet family YNL spec and unicast notification support
Date: Fri, 22 May 2026 09:00:31 -0700	[thread overview]
Message-ID: <20260522090031.40e809cb@kernel.org> (raw)
In-Reply-To: <20260522032447.238715-1-houminxi@gmail.com>

On Fri, 22 May 2026 11:24:47 +0800 Minxi Hou wrote:
> Sashiko flagged a few things on this series, noting my analysis here
> for the record.
> 
> The dp-ifindex field is typed as u32 in the spec while the kernel
> struct uses "int".  All three existing OVS specs (ovs_datapath,
> ovs_flow, ovs_vport) also use u32 for this field, so I kept it
> consistent.
> 
> key/actions/egress-tun-key are typed as binary rather than nest.
> This is documented in the commit message and inline comments --
> the nested attribute-sets belong to ovs_flow's spec, and YNL does
> not support cross-spec references.
> 
> The execute operation does not carry uns-admin-perm in the spec.
> The kernel sets GENL_UNS_ADMIN_PERM on it, but none of the existing
> OVS specs declare admin-perm flags on any of their operations either
> (ovs_datapath new/del/set, ovs_flow new/del/set, ovs_vport new/del/set
> all have GENL_UNS_ADMIN_PERM in the kernel but omit it in the YAML).
> 
> ntf_bind() will raise OSError if the socket was already bound.
> ntf_subscribe() has the same constraint -- both expect to be called
> before any operation that triggers autobind.

Your explanations sound reasonable.
But please rebase and repost, I think some patches merged yesterday
will conflict with the new ynl helper.
-- 
pw-bot: cr

      reply	other threads:[~2026-05-22 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  2:20 [PATCH net-next v4 0/2] Add OVS packet family YNL spec and unicast notification support Minxi Hou
2026-05-21  2:20 ` [PATCH net-next v4 1/2] netlink: specs: add OVS packet family specification Minxi Hou
2026-05-21  2:20 ` [PATCH net-next v4 2/2] tools: ynl: add unicast notification receive support Minxi Hou
2026-05-22  3:24 ` [PATCH net-next v4 0/2] Add OVS packet family YNL spec and unicast notification support Minxi Hou
2026-05-22 16:00   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260522090031.40e809cb@kernel.org \
    --to=kuba@kernel.org \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=houminxi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox