From: Jakub Kicinski <kuba@kernel.org>
To: weixiansen574 <weixiansen574@163.com>
Cc: netdev@vger.kernel.org, avinash.duduskar@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfp: add quirk for OEM 2.5G optical modules
Date: Fri, 22 May 2026 17:14:33 -0700 [thread overview]
Message-ID: <20260522171433.66a9c38d@kernel.org> (raw)
In-Reply-To: <20260520151629.905-1-weixiansen574@163.com>
On Wed, 20 May 2026 23:16:29 +0800 weixiansen574 wrote:
> Signed-off-by: weixiansen574 <weixiansen574@163.com>
A more official looking name is required.
Unicode characters are accepted FWIW, doesn't have to be westernized.
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index bd970f753..6f3213793 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -583,6 +583,8 @@ static const struct sfp_quirk sfp_quirks[] = {
> SFP_QUIRK_S("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
> SFP_QUIRK_S("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
> SFP_QUIRK_S("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
> + SFP_QUIRK_S("OEM", "SFP-2.5G-LH20-A", sfp_quirk_2500basex),
> + SFP_QUIRK_S("OEM", "SFP-2.5G-LH03-B", sfp_quirk_2500basex),
This list looks sorted, and I'd think LH03-B is before LH20-A
because of the number?
--
pw-bot: cr
prev parent reply other threads:[~2026-05-23 0:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 15:16 [PATCH] net: sfp: add quirk for OEM 2.5G optical modules weixiansen574
2026-05-23 0:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522171433.66a9c38d@kernel.org \
--to=kuba@kernel.org \
--cc=avinash.duduskar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weixiansen574@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox