From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6437833E7; Sat, 23 May 2026 01:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779500749; cv=none; b=HXsYR0te7HbI9bwcMHn29vaS520SwtwczmD7TV/UBkCZLNN3vVFn3KQP0Or0+6FszDpvay9LbVH9UCVBWYhyYOBDNgaChFuYwuCEObPUl0fCQf4SevGyG9pNbJZ0Tnp7hgPNM2ReiT9YZ2uN5MkOpXs3Mw/cPx4js5+YANzPtqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779500749; c=relaxed/simple; bh=npCUqI490PRptwu4ZGTwPcZzb4RCTp9ZxAj7I/pPMeI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aCmTd8phLOEsJ07kBmirJzjPo37n5zDTx3FaTWjH4Lcv3ASwvpcwn0DEOlohKOVJhIWVOa9qyqwsrdAM3wnubmPODVyh6Vav19qpetPfgUbGQjoE0u951LpPY0Ug8GIrQQtQOzGJRR52K5es6BkZuB1egPh6a7YCgalv1WIG6xY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MvtZEsG8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MvtZEsG8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD261F000E9; Sat, 23 May 2026 01:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779500748; bh=pvrv1h2YtaxLeHVYBfz/LqY0BX/aHmJKlWG1cpkGMaE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=MvtZEsG8FHoC78cJtO+Cdd6uqMGryX+mVwM0GiuLE0LDsBcQnfTHi59T1S1iQqJ0A CXTxULGnYSJyfxfIeCN9kPIaYd3qnU9B5PJXCmQChxSUVpEP+H8l9bJEDQAdn800NB MyeeNmSTM8wy4U4UPW1OW7OB+yyPvaZOla9Ax8o4cwIzd7ofMTzyITzNre2cNboIkC IJ+b9p7no/kxLVYouATjNEI66SeYGkKFnzwmKHFY5+wUZPuVbNet9RtjaatwjCncTk wfDkpVil5ol8dYNb+G1h1RgqmdYBHlrMQZSYj0Ax9HD1tr/n3SY2Wbb+U06cKBMOfd jvnP04P7fHv7w== Date: Fri, 22 May 2026 18:45:45 -0700 From: Jakub Kicinski To: Daniel Machon Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Horatiu Vultur , Steen Hegelund , , "Alexei Starovoitov" , Daniel Borkmann , "Jesper Dangaard Brouer" , John Fastabend , Stanislav Fomichev , Herve Codina , Arnd Bergmann , Greg Kroah-Hartman , Mohsin Bashir , , , , Subject: Re: [PATCH net-next v5 08/13] net: lan966x: add shutdown callback to stop FDMA on reboot Message-ID: <20260522184545.43e00be3@kernel.org> In-Reply-To: <20260520-lan966x-pci-fdma-v5-8-ca56197ae05b@microchip.com> References: <20260520-lan966x-pci-fdma-v5-0-ca56197ae05b@microchip.com> <20260520-lan966x-pci-fdma-v5-8-ca56197ae05b@microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 May 2026 10:12:20 +0200 Daniel Machon wrote: > + napi_synchronize(&lan966x->napi); > + napi_disable(&lan966x->napi); Why the synchronize() before disable() ? napi_synchronize() is a simplistic disable() + enable()