Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org,
	maxime.chevallier@bootlin.com, danieller@nvidia.com,
	petrm@nvidia.com, o.rempel@pengutronix.de, idosch@nvidia.com,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net 0/9] ethtool: module: fix a handful of small bugs
Date: Fri, 22 May 2026 16:13:03 -0700	[thread overview]
Message-ID: <20260522231312.1710836-1-kuba@kernel.org> (raw)

I've been poking at the locking in ethtool and it appears
that the FW flashing is not currently taking the ops lock.
Existing drivers which implement module FW flashing seem
to have their own locking, so this series doesn't actually
add the ops lock (I'll add it in net-next). But a number
of other errors have been surfaced in the process.

Jakub Kicinski (9):
  ethtool: module: call ethnl_ops_complete() on module flash errors
  ethtool: module: avoid leaking a netdev ref on module flash errors
  ethtool: module: avoid racy updates to dev->ethtool bitfield
  ethtool: module: check fw_flash_in_progress under rtnl_lock
  ethtool: module: fix cleanup if socket used for flashing multiple
    devices
  ethtool: cmis: require exact CDB reply length
  ethtool: cmis: fix u16-to-u8 truncation of msleep_pre_rpl
  ethtool: cmis: validate start_cmd_payload_size from module
  ethtool: cmis: validate fw->size against start_cmd_payload_size

 net/ethtool/cmis.h           |  4 ++--
 net/ethtool/netlink.h        |  4 ++--
 net/ethtool/cmis_cdb.c       |  9 ++++++--
 net/ethtool/cmis_fw_update.c | 44 ++++++++++++++++++++++++------------
 net/ethtool/module.c         | 41 ++++++++++++++++++++-------------
 net/ethtool/netlink.c        |  4 ++--
 6 files changed, 68 insertions(+), 38 deletions(-)

-- 
2.54.0


             reply	other threads:[~2026-05-22 23:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 23:13 Jakub Kicinski [this message]
2026-05-22 23:13 ` [PATCH net 1/9] ethtool: module: call ethnl_ops_complete() on module flash errors Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 2/9] ethtool: module: avoid leaking a netdev ref " Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 3/9] ethtool: module: avoid racy updates to dev->ethtool bitfield Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 4/9] ethtool: module: check fw_flash_in_progress under rtnl_lock Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 5/9] ethtool: module: fix cleanup if socket used for flashing multiple devices Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 6/9] ethtool: cmis: require exact CDB reply length Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 7/9] ethtool: cmis: fix u16-to-u8 truncation of msleep_pre_rpl Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 8/9] ethtool: cmis: validate start_cmd_payload_size from module Jakub Kicinski
2026-05-22 23:13 ` [PATCH net 9/9] ethtool: cmis: validate fw->size against start_cmd_payload_size Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260522231312.1710836-1-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox