From: Hungyu Lin <dennylin0707@gmail.com>
To: subash.a.kasiviswanathan@oss.qualcomm.com,
sean.tranchetti@oss.qualcomm.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Hungyu Lin <dennylin0707@gmail.com>
Subject: [PATCH] net: qualcomm: rmnet: clarify MAP command ACK behavior
Date: Sat, 23 May 2026 11:03:46 +0000 [thread overview]
Message-ID: <20260523110346.1672-1-dennylin0707@gmail.com> (raw)
rmnet_map_command() only sends ACK responses for supported
commands. Unsupported commands are dropped without sending
a response.
Update the comment to reflect the current behavior.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
index add0f5ade2e6..c1c3d4fc7a99 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
@@ -69,8 +69,8 @@ static void rmnet_map_send_ack(struct sk_buff *skb,
netif_tx_unlock(dev);
}
-/* Process MAP command frame and send N/ACK message as appropriate. Message cmd
- * name is decoded here and appropriate handler is called.
+/* Process MAP command frame and send ACK message for supported commands.
+ * Message cmd name is decoded here and the appropriate handler is called.
*/
void rmnet_map_command(struct sk_buff *skb, struct rmnet_port *port)
{
--
2.34.1
next reply other threads:[~2026-05-23 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 11:03 Hungyu Lin [this message]
2026-05-27 9:47 ` [PATCH] net: qualcomm: rmnet: clarify MAP command ACK behavior Simon Horman
2026-05-28 0:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260523110346.1672-1-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.tranchetti@oss.qualcomm.com \
--cc=subash.a.kasiviswanathan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox