From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A354317155 for ; Sat, 23 May 2026 16:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779554162; cv=none; b=BrwIa6sXTXvlzcrg+SM184Peihj4/QqjvhFp6eGK6qPPzOwb/jElUc0hBucfUmtFXXEVJTHVPVPQ+v20Bxbl9j38dpXJf8epY7oWvxzJCrBuTGryPRVM6SX22hulWYwRW3LkdHXJ99+DuhbmrnW3N23LD1ha98jnAAobypKNndI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779554162; c=relaxed/simple; bh=SnLk0HaLAeDp9CB1O+cT5QTtRXJhfOlf8pVOAJpSIsI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HmqiTACty9agSPMEXU65vlWoXCwiJwUjW/QiETnKbW8P6bG9XgPa+N+BpzxkEo9z6cqVf08mOanfiv8DibJ8ccOWZvewJzZFZ/EAN5pQmjeQysW6JgW9QrWu7sKcGj/MFEn6/ET0YBSna4AbiKKJshf9gwOPXX3wB/LMBE2ieW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ns5JaW3q; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ns5JaW3q" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-44ce78ab5feso6851935f8f.0 for ; Sat, 23 May 2026 09:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779554159; x=1780158959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Iqbi0SmV4l8cOiZU/jCD2RWz3CBg4dHUkTOED22sLyI=; b=ns5JaW3qxh1lKB1A1AMfQL/YNs5W71qvnoee8vLAr5LSlbmqX2Dqx/ltWDQ0JyqyQq j9Dyrhxwh+elQ1GwyrdeuUJ0eERgcDjdOIGbJ78IdpOsbkLY18/bJ4NlDgPuPnJclrlV IT4M8ixDjUtmC78JvcnUc0TZooSMJxLoKwDLeobqUeM5+CH0cc9ol1c0ntLESuS1H1Hb eEPuU+gpiJo7bagCd1eekOZIz/EU7Lt5ci9GXppLJqY2qCUBk7/qW5c6/QpMr/Rusbo7 p2QWaZwx5gO9PUHjRAzf0HEFly+cqoeLuBvDSkzfQErmOz/PoG2DHXu0ERATHhxuDCSh 2w0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779554159; x=1780158959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iqbi0SmV4l8cOiZU/jCD2RWz3CBg4dHUkTOED22sLyI=; b=DcsvOo5Bk0M7J/PEfv1BxR9uX3ELMl47Ob3Fo+ff9Sut8dGzuCPn0Xpl5o+9yYLgAZ HCkb+Y/3OHHF+JXolohJCCBX3+CRiORnbYBmlgySoEFjfcHcJTT9wilpr+8NdRCZm3jh MxDRSVgH7gRWdVoe9QggfmxxiR7piiaLnfrlhS/PfPbO8YcI0wSXcU/J7xBNE6E+e3EM kAYpsSih9IoMsNi5Zx6ScJfj+T9sUHs43L6UYVfs+fAm+4VjbDd3Osr8NBT0Sf1g2/vE 2ajJg5BlSQ9+unTtoQIrlusuYTHv5r3qMloDIwM93UtxErt/6Rt80Ha+JZiXb+DR1vS6 SVUQ== X-Forwarded-Encrypted: i=1; AFNElJ8X5FrybB4f2slZX4CqiQoA5lCXzFfR6sgqpTp8c+juBk607b9rce8TFqViE6+A23L+uunjO3M=@vger.kernel.org X-Gm-Message-State: AOJu0YwMIQzxj8jw7RX6ZNIC6RLCNwnpJoyNIcdx8Wcs1LtmtU3l5J87 tMiKXZW2+svgqJrp3pj0i/4D6bHzz5V/4jfGEa0Wbkl3CfoNXd6mAkYC X-Gm-Gg: Acq92OH7GVHz3aEfVGOLLCXT9VLfdFovz2OoTFG5TEDWp17k67W8qbkngTMvQXguYbv EtdOg6KN+2wrUmRX0UrBmih2zOEqqpE2N1XN0XiMu2rGKLbcBE8ovAJEKKzyFf5LufL5ewirJ3M Boh8Otz1xF5IKrG+LR1P4CgiENI5eb4Qdy80iBBKUvTGOoP1ZxnaObxTEpc8kV11i0SVB9bEMW7 Tl11JK6XowcrrEONHIyzs7m4QF3ShZWAZoQMMco8oEpgf+uI69aiiNVYXEuvdmUjGAFf49Lwddt ce6ZZKA4Bc+HpV8xCGALwyF4Sr7NLwbj945rsXqL3dPKsHlxeGZunAn9UHhA1bHwoQElkvDS4nG tD0eM1z0MG2HpG3yKojX2GTksaU+63mQb4LsbuNgurM2TCH3vFtP1hpVmfWl5LPC2Lkj0lGD9+Z +aXMdgv67TLTvU+ONnIt2XjnaRPB+Flz7tDzF6wRZAEtn/77jw0wBnIwLBXKowyJoJ X-Received: by 2002:a05:6000:29d3:b0:45d:3cbf:bdda with SMTP id ffacd0b85a97d-45eb38bb000mr9671985f8f.20.1779554159363; Sat, 23 May 2026 09:35:59 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d493dfsm13521078f8f.23.2026.05.23.09.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 09:35:59 -0700 (PDT) Date: Sat, 23 May 2026 17:35:57 +0100 From: David Laight To: patchwork-bot+netdevbpf@kernel.org Cc: Stefano Garzarella , netdev@vger.kernel.org, xuanzhuo@linux.alibaba.com, horms@kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kuba@kernel.org, eperezma@redhat.com, pabeni@redhat.com, mst@redhat.com, davem@davemloft.net, jasowang@redhat.com, stefanha@redhat.com, edumazet@google.com, stable@vger.kernel.org Subject: Re: [PATCH net] vsock/virtio: fix skb overhead overflow on 32-bit builds Message-ID: <20260523173557.5cc4f4f6@pumpkin> In-Reply-To: <177950282964.1445071.6600517211632117224.git-patchwork-notify@kernel.org> References: <20260521124732.125771-1-sgarzare@redhat.com> <177950282964.1445071.6600517211632117224.git-patchwork-notify@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 23 May 2026 02:20:29 +0000 patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This patch was applied to netdev/net.git (main) > by Jakub Kicinski : Did anyone else notice that is isn't a bug? There is no way that a 'count of bytes of kernel memory' can overflow the size of 'long'. -- David > > On Thu, 21 May 2026 14:47:32 +0200 you wrote: > > From: Stefano Garzarella > > > > On 32-bit architectures, both skb_queue_len() and SKB_TRUESIZE(0) evaluate > > to 32-bit values. The multiplication can overflow before being assigned to > > the u64 skb_overhead variable, making the skb overhead check ineffective. > > > > Cast skb_queue_len() to u64 so the multiplication is always performed in > > 64-bit arithmetic. > > > > [...] > > Here is the summary with links: > - [net] vsock/virtio: fix skb overhead overflow on 32-bit builds > https://git.kernel.org/netdev/net/c/4157501b9a8f > > You are awesome, thank you!