From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0184335F5E9 for ; Mon, 25 May 2026 19:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779738496; cv=none; b=IgXkSAUwqcepR7r/4//yABFsb6rx0cdODvEak5acOCY7CfC2md9WNBsdL5f9yeMj5bC/O2A9Am+UWvOJ0plSfo7BK9caKpXUo882Y8/KCxHnAHneuh27RG722LQqnAGHJ+G3hF3rUZnh5eV31OHDBoI6YBb0vkoJKegZWW9BAK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779738496; c=relaxed/simple; bh=6vvUpEnA3zuZyhkh5L9tx3acH0/PiR28xnODKHfdVgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hxSbIFxFi3qYRY6j/+lW9oGb78Zjy0osMywNhoF5diXovSuepGXfOZnsHK9KiHAanQqUo5bTMj0FV+rINWvHH8MyIDamCMd7NVSAI7xX9JECULsV+zlimqM0vdypXPxVmmAyeZlXafP28KVhSkccOMOT2hUGNr4/wdKe1h5qpjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XILNl8Wg; arc=none smtp.client-ip=209.85.222.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XILNl8Wg" Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-95cc96eac66so6856282241.1 for ; Mon, 25 May 2026 12:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779738494; x=1780343294; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rgdsNgCTJpv8k0KRcqQg2bYC+LqfZpfIBBy5KwRLQzE=; b=XILNl8WgO/VM03qD2UiuIr0fZ1NTUaLzdosSjSp9PLQzO1bzccTMrztDEA1/EXwDS2 Ape3cbecRIEeoCkIpr275kWMYeV3dtsSB0vU0wAF6n/URc26FBpWVpC4pNyGNI6VA4m0 87wzwm2orYabjHT5nLb7yMo2Z0Kjy5xINSUr62is5p9wHud6Y9Uv8k/KyLb0dAsRqcN2 szNXaj4VkuTkArw2BITOQvW2qUiqRZ2xPdw+kPuMGqebHaC6HinCyt4JBahxJDUCfC9S AsOxy/4+YePR96sIWoC76ATSwVkyTNWe16rjMhXVEa7z7ZnhThWFora09XmFTR8/1f8B P1+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779738494; x=1780343294; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rgdsNgCTJpv8k0KRcqQg2bYC+LqfZpfIBBy5KwRLQzE=; b=QsnDi880fBZ3WKvQ47E1aZZpBrnehh7cV8GCYhTsHj2OQkO5caSDwb5wxqREQT1j3m vv9CN0lBzR9BvlQZGVle/GQotgzkLb6OZ48CBVng7mU7dFUZBPM3CATXVKNbl3zk7Yiw 6WIuewnJYzXUEd0Zwkg89SV+IQvO2d9Gu1HOZJ9Kxkk+IrFmLELD0uox8S+XsjkMOndQ O1q6mGLG76G2hQ2l3EMYamZprsQQxskW0DzgjdGefx0kMXu2BO/mWGWYQZls+ve2JPpW 1+h8DVXvQ5HG3XAv4mR5DUHPzEFXKQk6+TdxbGGNT+r6kICV2HNfoSLpb8J70M4NQ7P8 fHnw== X-Gm-Message-State: AOJu0Ywqpbc8fhL7j6KYGhqgtPG6cpiRfxIZ/dOiLaLuDhdFt7+ZL1gj sE5G0VC5UuF5TmW0doz7UVXZUxA7pT2tSpicwnk36DpLINLaM285imCm X-Gm-Gg: Acq92OHWmYczC2L+6Xia1DVAIBwmnzEsSfbw1gAZ3v1Rlp7kqoDWJHgw/ChJTPvmNtd 8ht4447lRpyk8j9sswvI58mWDzG3Gf5tZr8fNUDOQdWkIn+IwANQZrkFFP8Cyp8f8yamH2ZiV/u bS9bqtUUep51vaVu1sjGsvJ0oXSzBMbZ2IwtNWI54n8G6UVdbJhJmtOQzO2QWhhldmX6LNsONXM 58QTjAJbe/kUSDqkYW5p7Apm7YBi8ntR7jOeU3IUnIRW6RxPdO3mX9kZpw+BmGERGwoKfFiWdGH 2lUZS2vVCguFXhmIXS+HY1cks5dmpP1zlG8TBx6P8ynaC21Fn0TDCD+ROajL/gmaA7hoAk1dSZq 4Y9l68m2lMT2Bkf1//BW2RUs03mtFnT9qq8GQzIIkXZCqoMSbOj0yQTUOPHI/q5e2ZTmvTC23sZ fed4uaHwPkE23mRbk1/sfALY/NSZ/V5Q0uYNvHEg== X-Received: by 2002:a05:6102:3f4b:b0:631:3bbb:f25f with SMTP id ada2fe7eead31-67c85c3396dmr8532000137.15.1779738493892; Mon, 25 May 2026 12:48:13 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-96173af3e82sm11092456241.10.2026.05.25.12.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 12:48:13 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Mon, 25 May 2026 16:47:57 -0300 Subject: [net-next PATCH v8 1/8] net: dsa: realtek: rtl8365mb: use ERR_PTR Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260525-realtek_forward-v8-1-5eb80a4675be@gmail.com> References: <20260525-realtek_forward-v8-0-5eb80a4675be@gmail.com> In-Reply-To: <20260525-realtek_forward-v8-0-5eb80a4675be@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mieczyslaw Nalewaj , Luiz Angelo Daros de Luca X-Mailer: b4 0.15.2 Convert numeric error codes into human-readable strings by using %pe together with ERR_PTR() in dev_err() messages. Also use dev_err_probe() instead of checking for -EPROBE_DEFER. Reviewed-by: Linus Walleij Reviewed-by: Mieczyslaw Nalewaj Signed-off-by: Luiz Angelo Daros de Luca --- drivers/net/dsa/realtek/rtl8365mb.c | 51 +++++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index 0da048da533a..2637884fe472 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -803,8 +803,8 @@ static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum) ret = rtl8365mb_phy_ocp_read(priv, phy, ocp_addr, &val); if (ret) { dev_err(priv->dev, - "failed to read PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to read PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -831,8 +831,8 @@ static int rtl8365mb_phy_write(struct realtek_priv *priv, int phy, int regnum, ret = rtl8365mb_phy_ocp_write(priv, phy, ocp_addr, val); if (ret) { dev_err(priv->dev, - "failed to write PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to write PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -1082,8 +1082,8 @@ static void rtl8365mb_phylink_mac_config(struct phylink_config *config, ret = rtl8365mb_ext_config_rgmii(priv, port, state->interface); if (ret) dev_err(priv->dev, - "failed to configure RGMII mode on port %d: %d\n", - port, ret); + "failed to configure RGMII mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1112,8 +1112,8 @@ static void rtl8365mb_phylink_mac_link_down(struct phylink_config *config, false, false); if (ret) dev_err(priv->dev, - "failed to reset forced mode on port %d: %d\n", - port, ret); + "failed to reset forced mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1143,8 +1143,8 @@ static void rtl8365mb_phylink_mac_link_up(struct phylink_config *config, rx_pause); if (ret) dev_err(priv->dev, - "failed to force mode on port %d: %d\n", port, - ret); + "failed to force mode on port %d: %pe\n", port, + ERR_PTR(ret)); return; } @@ -1299,8 +1299,8 @@ static void rtl8365mb_get_ethtool_stats(struct dsa_switch *ds, int port, u64 *da mib->length, &data[i]); if (ret) { dev_err(priv->dev, - "failed to read port %d counters: %d\n", port, - ret); + "failed to read port %d counters: %pe\n", port, + ERR_PTR(ret)); break; } } @@ -1652,7 +1652,8 @@ static irqreturn_t rtl8365mb_irq(int irq, void *data) return IRQ_HANDLED; out_error: - dev_err(priv->dev, "failed to read interrupt status: %d\n", ret); + dev_err(priv->dev, "failed to read interrupt status: %pe\n", + ERR_PTR(ret)); out_none: return IRQ_NONE; @@ -1725,10 +1726,13 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) /* rtl8365mb IRQs cascade off this one */ irq = of_irq_get(intc, 0); if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(priv->dev, "failed to get parent irq: %d\n", - irq); - ret = irq ? irq : -EINVAL; + if (!irq) { + dev_err(priv->dev, "failed to map IRQ\n"); + ret = -EINVAL; + } else { + ret = dev_err_probe(priv->dev, irq, + "failed to get parent irq\n"); + } goto out_put_node; } @@ -1790,7 +1794,8 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) ret = request_threaded_irq(irq, NULL, rtl8365mb_irq, IRQF_ONESHOT, "rtl8365mb", priv); if (ret) { - dev_err(priv->dev, "failed to request irq: %d\n", ret); + dev_err(priv->dev, "failed to request irq: %pe\n", + ERR_PTR(ret)); goto out_remove_irqdomain; } @@ -1966,14 +1971,16 @@ static int rtl8365mb_setup(struct dsa_switch *ds) ret = rtl8365mb_reset_chip(priv); if (ret) { - dev_err(priv->dev, "failed to reset chip: %d\n", ret); + dev_err(priv->dev, "failed to reset chip: %pe\n", + ERR_PTR(ret)); goto out_error; } /* Configure switch to vendor-defined initial state */ ret = rtl8365mb_switch_init(priv); if (ret) { - dev_err(priv->dev, "failed to initialize switch: %d\n", ret); + dev_err(priv->dev, "failed to initialize switch: %pe\n", + ERR_PTR(ret)); goto out_error; } @@ -2091,8 +2098,8 @@ static int rtl8365mb_detect(struct realtek_priv *priv) ret = rtl8365mb_get_chip_id_and_ver(priv->map, &chip_id, &chip_ver); if (ret) { - dev_err(priv->dev, "failed to read chip id and version: %d\n", - ret); + dev_err(priv->dev, "failed to read chip id and version: %pe\n", + ERR_PTR(ret)); return ret; } -- 2.54.0