From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f201.google.com (mail-qt1-f201.google.com [209.85.160.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 806073E3C48 for ; Mon, 25 May 2026 08:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698149; cv=none; b=rEEqo9HfYCKVVvk/Snlkp4ZkcWWWj+uFcgZKeTEwqWuqrbC+so0HdGbOGbb9WR5kG5MIInS765lNJa07eIPlwQPHnCwGrSrbCvkr8uqCJT+geYHtMCTJaIG3CNgTtYlWcy6ER/1yMPxvJn8XEQXJlHCXRckEASvcXc8a9n2srCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698149; c=relaxed/simple; bh=Fm6VNA3xzudmTAgja+duumR97nrJWZbAExcE4EzbtiE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oUiidLISPBIxw5syEX9KOBez/cAEvChabgf60XkauLrZk/Vzf3q6bb+QQY53xNH5GATCsmKV5VHqFo78uYIlwUQzLyw8gAwwkHKMQZEyTzRKajkuzl81O2NKwuT4GmV1oxrr4fGEYhSnKD0nOmNU8CPOOyvQIyO3VwbEjJLJNzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=q+tOoOx9; arc=none smtp.client-ip=209.85.160.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="q+tOoOx9" Received: by mail-qt1-f201.google.com with SMTP id d75a77b69052e-516e0846095so38764191cf.0 for ; Mon, 25 May 2026 01:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779698147; x=1780302947; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MYdMnQmiPN41CnN+XQjD2+Uwgzy/HF3jAtG3QIC0KLE=; b=q+tOoOx9pmpkPXXDD5QYygwczijYFvtpv7hzEXYeZ29PNTbazdHwWwpwRPXM1p/3j/ uymSwTEdAlbSSvKDVDkyOoL09Mn89AHbPGx3znM7joQoOXTBiO3zA+XvcUbQ3mZrufMI 2RBxvBx387W2dCaHgicjcIzWgl5ldvmMGdNVrWDvixaxXL48Xn1H76FN7XhgnTwoKui1 615jpD2trakB1W0/1oyFyB4q6VfdeNhMcVCw1N9TmWkweUxJ0y9wQ07lEaFezlldQRB/ ukLQR6Y1cJe8RYY0tDr0O9Y8L1a5ZZ8B5Q4GnVsZdmjHWazQit54i5LVA7qNH+ElHIof 4IPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779698147; x=1780302947; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MYdMnQmiPN41CnN+XQjD2+Uwgzy/HF3jAtG3QIC0KLE=; b=TlRCeqUS3dl0S+kkyIht/0cUvZVtHjiFotrAs3o9lUVPjNKN3TpJr9O3gfA4hleXLR dYTXVdVvy5u++EpIQGzc70x6QzsGUV4lank+nKCr2PpVe2qhZT8d5tngwzMY4P9fEL7B wGahit3iqOoSrHXJQmTOZXs0kc/J/Zd+k0YreDQWSyJYq/hYTzK73K3xegC0rpXeOTmq Uy1g/nBt2L9yWsdVkzDiuJ45FUiNgN+beWSHB/WNnHK78ZaBkhvEz/50InwGgHruoVnN QaFiIhitjX0uQSf17A3e4j4+R0BP7f0sZbbvf5IHerqTHqpzvROcvqiFLB6ASn0cVO+0 QEqw== X-Forwarded-Encrypted: i=1; AFNElJ/MZw7JJn/iA38uHw+Ar5VUQGgcXjLSXLBXCIKdyO/lw8jgaTv4x/rsvLt22csMioKoSp7M01I=@vger.kernel.org X-Gm-Message-State: AOJu0YzDpqoYlCIlNW5IR2MN5fXUTmI4d0nG/6Ax5Lm5hRNPZFEkZNO4 C44SiRXrhp8Jm64nEI2yPDXSDpAM6b51MknjqcbCoLyVTxJY3U6wMD795Bcb5qoDMxWFhOMXRYe re4G0ZSkYZZ73gg== X-Received: from qtpd5.prod.google.com ([2002:ac8:6685:0:b0:516:c9b1:8ef2]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:622a:1441:b0:516:da58:35c with SMTP id d75a77b69052e-516da58061bmr160535021cf.24.1779698147272; Mon, 25 May 2026 01:35:47 -0700 (PDT) Date: Mon, 25 May 2026 08:35:39 +0000 In-Reply-To: <20260525083542.1565964-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260525083542.1565964-1-edumazet@google.com> X-Mailer: git-send-email 2.54.0.746.g67dd491aae-goog Message-ID: <20260525083542.1565964-3-edumazet@google.com> Subject: [PATCH v5 net-next 2/5] net: defer netdev_name_node_alt_flush() call to netdev_run_todo() From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" In the following patch, we want to call rtnl_fill_prop_list() without RTNL being held, but after a device reference was taken. We need to free altnames in netdev_run_todo() instead of unregister_netdevice_many_notify(). Freeing will only happen once all device references have been released. Note that dev->name_node serves as the anchor for altnames, thus must be also freed in netdev_run_todo(). Signed-off-by: Eric Dumazet Reviewed-by: Kuniyuki Iwashima --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 26ac8eb9b259d489159c7ab5a2b206d425110b3b..2d795f3f569be00361809823fd3e59fb1871919c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -11738,6 +11738,8 @@ void netdev_run_todo(void) WARN_ON(rcu_access_pointer(dev->ip_ptr)); WARN_ON(rcu_access_pointer(dev->ip6_ptr)); + netdev_name_node_alt_flush(dev); + netdev_name_node_free(dev->name_node); netdev_do_free_pcpu_stats(dev); if (dev->priv_destructor) dev->priv_destructor(dev); @@ -12451,8 +12453,6 @@ void unregister_netdevice_many_notify(struct list_head *head, dev_uc_flush(dev); dev_mc_flush(dev); - netdev_name_node_alt_flush(dev); - netdev_name_node_free(dev->name_node); netdev_rss_contexts_free(dev); -- 2.54.0.746.g67dd491aae-goog