From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Kuniyuki Iwashima <kuniyu@google.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Damiano Melotti <melotti@google.com>
Subject: Re: [PATCH net] tunnels: do not assume transport header in iptunnel_pmtud_check_icmp()
Date: Mon, 25 May 2026 11:54:49 -0700 [thread overview]
Message-ID: <20260525115449.4e0895ba@kernel.org> (raw)
In-Reply-To: <CANn89i+h3d=SoK4S3iUFvQ8fb=iBbBTX+yoM-Ey6ya+BnsAJTA@mail.gmail.com>
On Mon, 25 May 2026 11:41:59 -0700 Eric Dumazet wrote:
> > Are we okay with what sashiko is reporting?
> > If it's legit it may be better to fix in one series
>
> Maybe, but iptunnel_pmtud_check_icmpv6() is also calling
> pskb_may_pull(), and always had.
>
> Perhaps it is time for CONFIG_DEBUG_NET kernels to always reallocate
> skb->head at every pskb_may_pull() call, just to expose these bugs.
Ack, but callers may ensure pulling just the ip header is already safe
at this point vs pulling an extra L4 hdr.
> I fear that a series will never be complete, sashiko will keep finding issues.
>
> I can try a V2, but will probably give up soon.
Thanks, let's try v2. If it turns into a rabbit hole we can just apply
v1, LMK.
prev parent reply other threads:[~2026-05-25 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 11:55 [PATCH net] tunnels: do not assume transport header in iptunnel_pmtud_check_icmp() Eric Dumazet
2026-05-25 2:55 ` Kuniyuki Iwashima
2026-05-25 18:20 ` Jakub Kicinski
2026-05-25 18:41 ` Eric Dumazet
2026-05-25 18:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525115449.4e0895ba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=melotti@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox