From: Jakub Kicinski <kuba@kernel.org>
To: Christopher Lusk <clusk@northecho.dev>
Cc: John Fastabend <john.fastabend@gmail.com>,
Sabrina Dubroca <sd@queasysnail.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] net: tls: preserve split open record on async encrypt
Date: Mon, 25 May 2026 13:30:28 -0700 [thread overview]
Message-ID: <20260525133028.58494274@kernel.org> (raw)
In-Reply-To: <20260521025840.976378-2-clusk@northecho.dev>
On Wed, 20 May 2026 22:58:39 -0400 Christopher Lusk wrote:
> When the BPF sk_msg verdict sets apply_bytes smaller than the current
> open record, tls_push_record() splits ctx->open_rec into the record
> being encrypted and a remainder record. The synchronous path reattaches
> the remainder to ctx->open_rec before continuing.
The current understanding is that this code has no real users.
So let's try clear async_capable if BPF is attached and avoid
all these bugs in record handling, please? The savings from
zero copy are negligible.
next prev parent reply other threads:[~2026-05-25 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 2:58 [PATCH net v2 0/2] net: tls: fix async split record handling Christopher Lusk
2026-05-21 2:58 ` [PATCH net v2 1/2] net: tls: preserve split open record on async encrypt Christopher Lusk
2026-05-25 20:30 ` Jakub Kicinski [this message]
2026-05-21 2:58 ` [PATCH net v2 2/2] selftests: net: add kTLS async split record regression Christopher Lusk
2026-05-25 20:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525133028.58494274@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clusk@northecho.dev \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox