From: Ido Schimmel <idosch@nvidia.com>
To: Yuyang Huang <sigefriedhyy@gmail.com>
Cc: Jiayuan Chen <jiayuan.chen@linux.dev>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] ipv4: igmp: annotate data-races around im->users
Date: Mon, 25 May 2026 17:02:57 +0300 [thread overview]
Message-ID: <20260525140257.GB215190@shredder> (raw)
In-Reply-To: <CA+7S2vJc7F__vWiprT9bT__+CUwSN_=jssAiu=GiLZG-Ho662Q@mail.gmail.com>
On Sun, May 24, 2026 at 11:05:43PM +0900, Yuyang Huang wrote:
> >This one isn't necessary since the object was just allocated and not yet
> >published
>
> Thanks for the comment. I did consider not modifying it when writing
> the patch, but decided to keep it for consistency, it makes the code
> easier to reason about later. If you feel strongly about removing it,
> I'm happy to send a v3.
I don't think it's worth another version. Personally I wouldn't add
WRITE_ONCE() where it's not necessary.
P.S. Please don't top post.
next prev parent reply other threads:[~2026-05-25 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 9:39 [PATCH net-next v2] ipv4: igmp: annotate data-races around im->users Yuyang Huang
2026-05-22 10:38 ` Jiayuan Chen
2026-05-22 11:07 ` Eric Dumazet
2026-05-24 13:59 ` Ido Schimmel
2026-05-24 14:05 ` Yuyang Huang
2026-05-25 14:02 ` Ido Schimmel [this message]
2026-05-25 18:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525140257.GB215190@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sigefriedhyy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox