From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F5636B044; Wed, 27 May 2026 02:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779849267; cv=none; b=bAIOugjj6lxHbCVo8KLSSu01aYsLYa+ABqBJEC/Gir3SKnJfdfd46+USKtEm1yargrwxK98g6jmAh1pl6GOFuy21MiYPcaMslfx4iDjePBl6ifdyo7nv2scqdIb/gU6T5B/6jM2lMms0mrxfokro96PAghjoI/Ku+194KgvejrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779849267; c=relaxed/simple; bh=6Y0ISuxZgz/P3ld5rbFvop5CRCFHLlT0T5DbHrF2OXg=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lGmcJeYQjBQ3xZuwdpLJANsLdh/1wqHoiEs4RKuq36vOcUba86aq3cDn/7bx9gLiMQxo1ncynShy04WOvBB6KIk7uwsokR4weoDjDKKuRDLmuKwCTo8OCt3j3mRFp+t7Z0XFmsq1rbkFQq4BYkUHLuQXkqhjwE1Um1sX0pkqUnE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jzVLad9+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jzVLad9+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91D161F00A3A; Wed, 27 May 2026 02:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779849266; bh=33Q+0nVF0ARpJV3lvmXHvrP9ISNqoJj90QlqqmgjQNA=; h=From:To:Subject:Date:In-Reply-To:References; b=jzVLad9+nE56KDu1h3aMww3nqpNvDXTwr7J4v/OOi/r0PlFae7me6gkMl80vPIkPZ Lf6LxW19vf0A0QLnYh3h2R2I/KyAJrq+f6fBtDrRG7b4z+AkgToVJ1lDV8ewQ34hHE J6kub8Ggumc2s9mAp8I5lWZazw0wjiK65cenqpihgONIb/KHdCsj+kNsw3jDW7Ezuz pna4SAA+Osjm/TLvr86eZFnIbOGg+hEQL+0OyYtjdUXh5AreDQWtbjhW2J6w834qKJ 21CnBy02Ou2mp7dhumdladW/cm3SySsObSRFnufkyxChpHyHCzmfuLD0J+o526MlBm ETS6ThsfV2VfQ== From: Allison Henderson To: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, kuba@kernel.org, horms@kernel.org, linux-rdma@vger.kernel.org, achender@kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: [PATCH net-next v2 2/4] selftests: rds: pin RDS sockets to their intended transport Date: Tue, 26 May 2026 19:34:21 -0700 Message-Id: <20260527023423.387792-3-achender@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260527023423.387792-1-achender@kernel.org> References: <20260527023423.387792-1-achender@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RDS selftests create AF_RDS sockets but never selects a transport, so the transport is chosen implicitly based on network topology when the socket is bound. If underlying connection establishment fails, RDS can fall back to another transport (e.g. loopback) and the test still passes, silently bypassing the intended datapath it is meant to exercise. Set SO_RDS_TRANSPORT to the proper RDS_TRANS_IB or RDS_TRANS_TCP before they are bound, so the test fails loudly if the intended transport is unavailable rather than passing on a different path. Signed-off-by: Allison Henderson --- tools/testing/selftests/net/rds/test.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py index 08f2a846a8ab5..9e4df01cb0d4b 100755 --- a/tools/testing/selftests/net/rds/test.py +++ b/tools/testing/selftests/net/rds/test.py @@ -59,6 +59,14 @@ rdma_addrs = [ OP_FLAG_TCP = 0x1 OP_FLAG_RDMA = 0x2 +# from include/uapi/linux/rds.h: SO_RDS_TRANSPORT pins a socket to a +# specific RDS transport so connection setup cannot silently fall back +# to another (e.g. loopback) transport. +SOL_RDS = 276 +SO_RDS_TRANSPORT = 8 +RDS_TRANS_TCP = 2 +RDS_TRANS_IB = 0 + signal_handler_label = "" tap_idx = 0 @@ -214,11 +222,21 @@ def snd_rcv_packets(env): netns_socket(netns_list[0], socket.AF_RDS, socket.SOCK_SEQPACKET), netns_socket(netns_list[1], socket.AF_RDS, socket.SOCK_SEQPACKET), ] + + # Pin the sockets to the TCP transport so it doesn't fail over to a + # different transport during this test + for s in sockets: + s.setsockopt(SOL_RDS, SO_RDS_TRANSPORT, RDS_TRANS_TCP) elif flags & OP_FLAG_RDMA: sockets = [ socket.socket(socket.AF_RDS, socket.SOCK_SEQPACKET), socket.socket(socket.AF_RDS, socket.SOCK_SEQPACKET), ] + + # Pin the sockets to the RDMA transport so it doesn't fail over to a + # different transport during this test + for s in sockets: + s.setsockopt(SOL_RDS, SO_RDS_TRANSPORT, RDS_TRANS_IB) else: raise RuntimeError(f"Invalid transport flag sets no transports: {flags}") -- 2.25.1