From: Simon Horman <horms@kernel.org>
To: han.junyang@zte.com.cn
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, ran.ming@zte.com.cn,
han.chengfei@zte.com.cn, zhang.yanze@zte.com.cn
Subject: Re: [PATCH net-next v4 1/2] net/ethernet: add ZTE network driver support
Date: Wed, 27 May 2026 10:27:08 +0100 [thread overview]
Message-ID: <20260527092708.GG2256768@horms.kernel.org> (raw)
In-Reply-To: <20260523174117467bbQo_yaI9XS_2nfd7pO6u@zte.com.cn>
On Sat, May 23, 2026 at 05:41:17PM +0800, han.junyang@zte.com.cn wrote:
> From: Junyang Han <han.junyang@zte.com.cn>
>
> Add basic framework for ZTE DingHai ethernet PF driver, including
> Kconfig/Makefile build support and PCIe device probe/remove skeleton.
>
> Signed-off-by: Junyang Han <han.junyang@zte.com.cn>
I think that a better prefix for this patch would be dinghai
Subject: [PATCH ...] dinghai: ...
And I would this for patch 2/2 too.
...
> diff --git a/drivers/net/ethernet/zte/dinghai/en_pf.c b/drivers/net/ethernet/zte/dinghai/en_pf.c
...
> +static int dh_pf_pci_init(struct dh_core_dev *dev)
...
> + if (!pf_dev->pci_ioremap_addr[0]) {
> + ret = -ENOMEM;
> + dev_err(dev->device, "ioremap(0x%llx, 0x%llx) failed\n",
> + pci_resource_start(dev->pdev, 0),
> + pci_resource_len(dev->pdev, 0));
For ARM allmodconfig builds, Clang 22.1.0 complains that:
drivers/net/ethernet/zte/dinghai/en_pf.c:70:4: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
69 | dev_err(dev->device, "ioremap(0x%llx, 0x%llx) failed\n",
| ~~~~
| %x
70 | pci_resource_start(dev->pdev, 0),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Looking at Documentation/core-api/printk-formats.rst, I expect the solution
is to use %pa[p] as the format specifier.
...
prev parent reply other threads:[~2026-05-27 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 9:41 [PATCH net-next v4 1/2] net/ethernet: add ZTE network driver support han.junyang
2026-05-27 0:41 ` Jakub Kicinski
2026-05-27 9:27 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527092708.GG2256768@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=han.chengfei@zte.com.cn \
--cc=han.junyang@zte.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ran.ming@zte.com.cn \
--cc=zhang.yanze@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox