From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5490F3EDAC9; Wed, 27 May 2026 09:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779875978; cv=none; b=ErBjyeuVub+qaOgZ+nMPJw/69axuqSt3cF4WA2MBs3BkFEIgb5xm8geYsTcKO0a3C0vlYn4IIQvf4V/xt9CXAzUFo8wu2ddyMMIvHX4fOdPW8VaU7D5jpl0EqJnyQNHQId6L52ePIEPanRZT3Y4v7M27zVmoGzZ2lMmPMy0TVoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779875978; c=relaxed/simple; bh=8jcWe1lSXPi8AtoGCRoAZPlzqi44Xs4vGacyQu214wE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dirLzes3CwpfbZGdloCH6Ve+g7tHpYEOfNGKDMr/NKP1QXBQy8T9k4j7RCxmvHJr63B/9vZVknYK+VYKtVmerKh3tTfRLa8SJEPpu4RhkvBo2KCUNS9ZYdNYRWic9BBsnO1luoS0Bewm/ZT731i7AV43kEVvQPyjOpK58nDqxRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=djcDzIaf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="djcDzIaf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 500CF1F00A3C; Wed, 27 May 2026 09:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779875974; bh=9dQ75g70aeWaKdWOHbU4z5KAG44IWr2RpHH814ZtOoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=djcDzIafs26gpX/TSJ06yDTouE7XBvDWcEUEePhQrjXA0c/pu8YJJPdpA8GhKWobZ 5wgo7DX+IscoA2RCDbDprFX+I7zH+J0m50IH3TjR4NxhRdGuVp9EanGxlP/ALRqcct OvyCBLKuEOJSdM3qV8OJzPCzWBFM/p7a90nlLFFW9eRaw7xM5nhFLJOk0HZ62hgRpZ f8NwOe6uwfeAYXLoNnOM6Mh4axLwBC4ptT8swT544eXwmdLnN4WXQnjgg1Fy5odPYC e8Y6wKf/deeDLbyTEtn/PjBBSHD5UZwnJIOX8w+KUT5SISbiY/K8r+zmoeAUEUqvis xVOxE6ROS+fiA== Date: Wed, 27 May 2026 10:59:30 +0100 From: Simon Horman To: Jijie Shao Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, shenjian15@huawei.com, liuyonglong@huawei.com, chenhao418@huawei.com, huangdonghua3@h-partners.com, yangshuaisong@h-partners.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 net-next 0/6] net: hns3: enhance tc flow offload support Message-ID: <20260527095930.GI2256768@horms.kernel.org> References: <20260523105449.661848-1-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260523105449.661848-1-shaojijie@huawei.com> On Sat, May 23, 2026 at 06:54:43PM +0800, Jijie Shao wrote: > This patchset enhances the tc flow offload support for hns3 driver: > > - Patch 1: Refactor hclge_add_cls_flower() to support more actions > - Patch 2: Improve unused_tuple parameter setting for separate src/dst configuration > - Patch 3: Add support for HCLGE_FD_ACTION_SELECT_QUEUE and HCLGE_FD_ACTION_DROP_PACKET actions > - Patch 4: Add support for FLOW_DISSECTOR_KEY_IP and FLOW_DISSECTOR_KEY_ENC_KEYID dissectors > - Patch 5: Add debugfs support for dumping FD rules > - Patch 6: Move FD code to a separate file (hclge_fd.c) for better code organization > > --- > ChangeLog: > v1 -> v2: > - Fixed warnings similar to "warning: restricted __le32 degrades to integer", > pointed out by Jakub > - Fixed warnings related to > "warning: diagnostic behavior may be improved by adding the 'format(printf, 5, 7)'", > pointed out by Jakub > v1: https://lore.kernel.org/all/20260518093526.1109595-1-shaojijie@huawei.com/ Hi Juijie, There are AI-generated reviews of this patch-set available at https://netdev-ai.bots.linux.dev/ and https://sashiko.dev/ I would appreciate it if you could look over them and address any issues that are either introduced by this patch-set, or directly impact it. I would not suggest expanding this patchset to address any other pre-existing issues, but rather address them separately as appropriate.