From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8AF918DB26; Thu, 28 May 2026 00:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928573; cv=none; b=NMmWbt4xGj7L9jTGSjfzOauouWd4NwxnS1pKdzAsdI4C+/eoTHyCAAIJDuIJ6B70IcFypAfhSMa7wZdxUWlFsnvVtKKvylhK3kt+ZSmU6IGmf9RW/Jj2oe+UDQce/bwDSBG9jtWRKLw5L0nYPG4POPcHQj6V1lZ+dSVjN4v9ptI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779928573; c=relaxed/simple; bh=mYVca3FZPB0gt2uk1hx49vfFInh5ZueWSY16U5I9L4w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IHApa605Zg79I6/v3zRfANi+sL4/qLicwqQOvyhpaPb6hDV1t+irXB2CWZIXUONVf1So4tgY+TYCgE9beNTKj3Fy8n4DFsLKNmr8dfILkXkUR0UUTzirAm2s2+1y9Gvtam+7O8pH314mtOcxEi8Tbu3E9j6cpoIrZx9PlUvy5fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AZ8HaB4T; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AZ8HaB4T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 754171F000E9; Thu, 28 May 2026 00:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779928572; bh=mYVca3FZPB0gt2uk1hx49vfFInh5ZueWSY16U5I9L4w=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=AZ8HaB4TZUtRQ0kSQ8iqNdj5ztNB8q9/8pkitIP/IkUEpOHrPuDLFARtER0HGb556 lEXy3fuXq4mcRoq5P34Fw630YyIuDuPcfdIG1Xt6J4+fAIrVuGLJxJfqtaGJBDPI6o GU7SO3FQR3r112v2kyk6hPvkrHqvfOuNPGOkm8vdR20TyLr7AimbDyKYeqPpcpP1S3 fuhGnCg/1hoqsi/36QwGKdaTlHXEOX3OZhby/0xgvSkHVn6uMvZFT4DZXiT+rvItC4 n5iijb7me1yZg/LvkN82AjTZyVxeKOzwSfMPZNekNdnBHFp9/MhTXZ2MAs6/Hnbsst 2ki3C49Z/9MyQ== Date: Wed, 27 May 2026 17:36:10 -0700 From: Jakub Kicinski To: Luiz Angelo Daros de Luca Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Linus Walleij , Alvin =?UTF-8?B?xaBpcHJhZ2E=?= , Yury Norov , Rasmus Villemoes , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yury Norov , Abdulkader Alrezej , Mieczyslaw Nalewaj Subject: Re: [net-next PATCH v8 5/8] net: dsa: realtek: rtl8365mb: add VLAN support Message-ID: <20260527173610.5cd14e85@kernel.org> In-Reply-To: <20260525-realtek_forward-v8-5-5eb80a4675be@gmail.com> References: <20260525-realtek_forward-v8-0-5eb80a4675be@gmail.com> <20260525-realtek_forward-v8-5-5eb80a4675be@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 25 May 2026 16:48:01 -0300 Luiz Angelo Daros de Luca wrote: > + * rtl8365mb_vlan_port_get_pvid - Retrieve the port PVID > + * @priv: realtek switch private structure > + * @port: port index > + * @pvid: pointer to store the retrieved VLAN ID > + * > + * Returns the port PVID if defined or 0 if not. > + * > + * Context: Can sleep. Takes and releases &priv->map_lock. > + * Returns 0 on success or a negative error code on failure. > + */ > +int rtl8365mb_vlan_port_get_pvid(struct realtek_priv *priv, int port, u1= 6 *pvid) Warning: drivers/net/dsa/realtek/rtl8365mb_vlan.c:686 No description found = for return value of 'rtl8365mb_vlan_port_get_pvid' Personal preference but IMHO use of kdoc on international driver functions is plenty pain for little gain. Maybe y'all use more advanced code editors or such that makes this useful? For me it's just lots of unnecessary metadata and kdoc warning risk, where a normal comment would do just fine to convey the information =F0=9F=A4=B7=EF=B8=8F=20 Rant over, your driver your call. > +/** > + * rtl8365mb_vlan_mc_find() - find VLANMC index by VID or the first free= index > + * > + * @priv: realtek_priv pointer > + * @vid: VLAN ID > + * @index: found index > + * @first_free: found free index > + * > + * If a VLAN MC entry using @vid was found, @index will return the match= ed index > + * and @first_free is undefined. If not found, @index will return 0 and > + * @first_free will return the first found free index in VLAN MC or 0 if= the > + * table is full. > + * > + * Although 0 is a valid VLAN MC index, it is reserved for ports without= PVID, > + * including standalone, non-member ports. It uses VID =3D=3D 0. > + * > + * Both @index and @first_free will be in the * 1..@RTL8365MB_VLAN_MCMAX= range. > + * > + * Return: Returns 0 on success, a negative error on failure. > + * > + */ nit: extra line at the end here --=20 pw-bot: cr