Re: [PATCH net-next v2 01/10] dt-bindings: net: Add ADIN1140

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2000 bytes --]

On Thu, May 28, 2026 at 04:46:54PM +0000, Regus, Ciprian wrote:
> > > +title: ADI ADIN1140 10BASE-T1S MAC-PHY
> > > +
> > > +maintainers:
> > > +  - Ciprian Regus <ciprian.regus@analog.com>
> > > +
> > > +description: |
> > > +  The ADIN1140 (also called AD3306) is a low power single port
> > 
> > Can you explain what is going on here please?
> > Is "adin1140" (which I can find no information easily online for) the
> > exact same device as the ad3306 (which has an entry on your site)?
> 
> The adin1140 is an upcoming version of ad3306 that lacks some
> (stress test) qualifications, but otherwise they are the exact same die.
> 
> > 
> > > +  10BASE-T1S MAC-PHY. It integrates an Ethernet PHY with a MAC
> > > +  and all the associated analog circuitry.
> > > +  The device tries to implement the Open Alliance TC6 10BASE-T1x MAC-
> > PHY
> > > +  Serial Interface specification and is compliant with the
> > > +  IEEE 802.3cg-2019 Ethernet standard for 10 Mbps single pair
> > > +  Ethernet (SPE). The device has a 4-wire SPI interface for
> > > +  communication between the MAC and host processor.
> > > +
> > > +allOf:
> > > +  - $ref: /schemas/net/ethernet-controller.yaml#
> > > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - adi,ad3306
> > > +      - adi,adin1140
> > 
> > Because if they are really two names for the same part, this compatible
> > setup makes no sense, as it means they have a different programming
> > models.
> 
> Since they have the same programming model, should I just keep the adi,adin1140
> entry?

If the ad3306 was the existing device, probably it should be the
compatible you keep, if you remove any.
Otherwise, just permit ad3306 as a fallback for adin1140:

compatible:
  oneOf:
    - items:
        - const: adi,adin1140
        - const: adi,ad3306
    - const: adi,ad3306

> 
> > 
> > Thanks,
> > Conor.
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]